Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of blunders #794

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Fix a couple of blunders #794

merged 2 commits into from
Sep 1, 2024

Commits on Sep 1, 2024

  1. BaseJob::encodeIfParam(): Use a regex to check the contents 

    Using a handcrafted condition is both longer and error-prone (see #793).
    @KitsuneRal
    KitsuneRal committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    631922c View commit details
    Browse the repository at this point in the history

  2. settings.*: revert from QAnyStringView back to QString 

    QAnyStringView (and any string view, in fact) cannot be used in
invocations from QML - meaning that anything Q_INVOKABLE in these files
cannot use string views.
    @KitsuneRal
    KitsuneRal committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    a80a6f8 View commit details
    Browse the repository at this point in the history