Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run a pkgdown_sitrep() at the end of each build? #2380

Closed
jayhesselberth opened this issue Nov 28, 2023 · 4 comments · Fixed by #2516
Closed

Run a pkgdown_sitrep() at the end of each build? #2380

jayhesselberth opened this issue Nov 28, 2023 · 4 comments · Fixed by #2516
Labels
feature a feature request or enhancement
Milestone
2.1.0

Comments

@jayhesselberth
Copy link
Collaborator

Seems useful to debug problems early.
@hadley

This comment was marked as outdated.

Sign in to view
@jayhesselberth

This comment was marked as outdated.

Sign in to view
@hadley

This comment was marked as outdated.

Sign in to view
@hadley
Copy link
Member

hadley commented Apr 11, 2024

If we do this, I think we'd need to figure out how to automate the "double-check" advice, since it's not going to be useful to advice people to double-check the urls after every run.

Also, the warning for first check could be improved:

# old
" is misconfigured. See {.vignette pkgdown::metatdata}."

# new
" is absent. See {.vignette pkgdown::metadata}."

@hadley hadley added the feature a feature request or enhancement label Apr 11, 2024
jayhesselberth added a commit that referenced this issue Apr 11, 2024
@jayhesselberth
Improve message if url is absent.
b642f2c 
part of #2380
@hadley hadley added this to the 2.1.0 milestone May 1, 2024
@hadley hadley changed the title Run a sitrep at the end of each build? Run a pkgdown_sitrep() at the end of each build? May 1, 2024
hadley added a commit that referenced this issue May 7, 2024
@hadley
Unify sitrep and check
ba9a60e 
* Introduce new `check_urls()` function that reports on url problems with errors and call it in `check_pkgdown()`
* `pkgdown_sitrep()` now calls the same functions as `check_pkgdown()` but wrapped in a helper to convert errors to messages
* `check_built()` is a separate concern so it's moved to a separate file

Fixes #2463. Fixes #2380.
@hadley hadley mentioned this issue May 7, 2024
Merged
@hadley hadley closed this as completed in 6804aa4 May 11, 2024
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
@jayhesselberth @SebKrantz
Improve message if url is absent.
b0ba498 
part of r-lib#2380
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
@hadley @SebKrantz
Unify sitrep and check (r-lib#2516)
a794973 
* Introduce new `check_urls()` function that reports on url problems with errors and call it in `check_pkgdown()`
* `pkgdown_sitrep()` now calls the same functions as `check_pkgdown()` but wrapped in a helper to convert errors to messages
* `check_built()` is a separate concern so it's moved to a separate file
* Improve articles checking by reusing reference checks.

Fixes r-lib#2463. Fixes r-lib#2380.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Unify sitrep and check r-lib/pkgdown
2 participants
@hadley @jayhesselberth