Unify sitrep and check #2516
Merged
Unify sitrep and check #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce new `check_urls()` function that reports on url problems with errors and call it in `check_pkgdown()` * `pkgdown_sitrep()` now calls the same functions as `check_pkgdown()` but wrapped in a helper to convert errors to messages * `check_built()` is a separate concern so it's moved to a separate file Fixes #2463. Fixes #2380.
hadley
commented
May 7, 2024
|
@jayhesselberth do you think you might have time to take a look at this next week? |
|
with And the vignette link doesn't work, see below for the same issue. # some misconfigured yaml
url: h
articles:
- title: Customise your site
navbar: ~
contents:
- customise
- linking
-
- metadata
reference:
- title: Build
desc: Build a complete site or one of its components.
contents:
- build_site
- starts_with("build_")
- -build_site_github_pages
- init_site
-
- pkgdown_sitrep
|
|
|
|
I suspect the vignette link doesn't work because the package hasn't been installed from CRAN, and thus doesn't have a built vignette. That code comes from cli, so I think is reliable. I'll take a look at the other issue; it's not directly related to the check/sitrep unification, but I might as well fix it while I'm here. |
|
With latest changes you now see |
|
Looks good to merge. |
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
* Introduce new `check_urls()` function that reports on url problems with errors and call it in `check_pkgdown()` * `pkgdown_sitrep()` now calls the same functions as `check_pkgdown()` but wrapped in a helper to convert errors to messages * `check_built()` is a separate concern so it's moved to a separate file * Improve articles checking by reusing reference checks. Fixes r-lib#2463. Fixes r-lib#2380.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_urls()function that reports on url problems with errors and call it incheck_pkgdown()pkgdown_sitrep()now calls the same functions ascheck_pkgdown()but wrapped in a helper to convert errors to messagescheck_built()is a separate concern so it's moved to a separate fileFixes #2463. Fixes #2380.