Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error on gcc 14.2 #2421

Closed
wants to merge 1 commit into from
Closed

Commits on Aug 8, 2024

  1. Fix compilation error on gcc 4.2

    R
    > devtools::install()
    
    Compilation error encountered with gcc 4.2:
    
    ```
    In file included from gdal.cpp:1:
    ./gdal.h:3:1: error: ‘OGRSpatialReference’ does not name a type; did you mean ‘DEFINED_OGRSpatialReferenc
    eH’?
        3 | OGRSpatialReference *handle_axis_order(OGRSpatialReference *sr);
          | ^~~~~~~~~~~~~~~~~~~
          | DEFINED_OGRSpatialReferenceH
    ./gdal.h:4:1: error: ‘Rcpp’ does not name a type
        4 | Rcpp::List create_crs(const OGRSpatialReference *ref, bool set_input);
          | ^~~~
    ```
    
    This commit forward declares `OGRSpatialReference` to fix the first
    error above, and it includes `Rcpp.h` explicitly to fix the second
    error.
    
    ```
    $ R --version
    R version 4.4.1 (2024-06-14) -- "Race for Your Life"
    
    $ gcc --version
    gcc (GCC) 14.2.1 20240802
    
    $ uname -a
    Linux durus 6.10.3-arch1-1 r-spatial#1 SMP PREEMPT_DYNAMIC Sun, 04 Aug 2024 05:11:32 +0000 x86_64 GNU/Linux
    ```
    djhshih committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8b0ea60 View commit details
    Browse the repository at this point in the history