Make in CI #12194
Merged
Make in CI #12194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-parallel-ct
branch
3 times, most recently
from
e1b35c6
to
5efb311
Compare
lhoguin
force-pushed
the
loic-parallel-ct
branch
18 times, most recently
from
219450c
to
ff8780b
Compare
lhoguin
force-pushed
the
loic-parallel-ct
branch
6 times, most recently
from
eaa0bd2
to
23cc737
Compare
This is very old code that is likely no longer used. Removing it helps avoid depending on cover.
The search results record change was done in OTP-25, which is no longer supported. So we can use the modern search results record and drop the compatibility clauses. For more context: * 8d8847e * erlang/otp#5538
And disable those checks in CI for now. We are getting errors because of the eetcd dependency and we can't upgrade at this time (see comment in the commit).
This can happen if the plugin isn't using CT, or if running Dialyzer, for example.
They are still enabled in the build job.
The fetch-tags option of actions/checkout@v4 does not work as intended so they are fetched manually instead.
All CT logs will now be under <toplevel>/logs. An improved test workflow would be to always keep the logs/all_runs.html page open in the browser and refresh it whenever tests are run in any of the rabbit applications.
As recommended by erlef/setup-beam.
Previously it was only available when TEST=1 was set.
Reverting back to the default 1 minute. The problem with 3 minutes is that this is exceedingly long and when there are problems the test time increases exponentially.
lhoguin
force-pushed
the
loic-parallel-ct
branch
from
a266a37
to
994abc1
Compare
The previous fix was leading to a badmatch in some cases, including when trying to stop a node that was already stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies
parallel-cttorabbitandrabbitmq_mqttand creates Make-based CI test workflows as a first step to converting CI to Make.Some failures are expected:
rabbitmq_trust_storeis due to a bug in OTP-27; the peer discovery AWS is probably related to a resource that needs to be cleaned up on the AWS front; and the rest are a handful of flakes that we can address over time. Due to recent work to reduce the number of flakes, the number is small, so a small team effort should get rid of near everything.This PR does not include mixed version testing which will continue using Bazel for the time being. A second PR will be worked on later to convert mixed version testing. Similarly, this is only enabled on
mainfor the time being.I will merge this to
maintomorrow (October 1st) unless there's any objections.