Make in CI #12194
Make in CI #12194
Commits on Sep 30, 2024
-
Merge feature_flags_with_unpriveleged_user_SUITE back in ff_SUITE
On GH Actions we run as an unprivileged user by default.
-
make: Move dep_osiris in rabbitmq-components.mk
Otherwise some plugins can't build if we try to run tests directly after checkout. This is because the plugins depend on osiris as well as rabbit, but there is no dep_osiris defined in the plugin itself.
-
This is a proof of concept that mostly works but is missing some tests, such as rabbitmq_mqtt or rabbitmq_cli. It also doesn't apply to mixed version testing yet.
-
mqtt tests: Move web_mqtt tests out of rabbitmq_mqtt
The shared test suite was renamed only for clarity, but the Web-MQTT test suites were renamed out of necessity: since we are now adding the MQTT test directory to the code path we need test suites to have different names to avoid conflicts. We can't (easily) addpath only for this test suite either since CT hooks don't call functions in a predictable enough manner; it would always be hacky.
-
-
-
-
-
-
-
-
-
make CI: Run most rabbitmq_peer_discovery_aws tests
The integration_SUITE has to run in a separate workflow due to needing secrets.
-
make: Fix build errors for apps that have rabbit in TEST_DEPS
We want them to install CLI scripts only for the test build, otherwise Dialyzer or others will fail in a clean run.
-
-
-
rabbit_common: Remove 'cover' related code from 'rabbit_misc'
This is very old code that is likely no longer used. Removing it helps avoid depending on cover.
-
-
-
ldap auth backend: Drop support for pre-OTP-25 search results
The search results record change was done in OTP-25, which is no longer supported. So we can use the modern search results record and drop the compatibility clauses. For more context: * 8d8847e * erlang/otp#5538
-
-
Fix some OTP-27 Dialyzer errors in rabbitmq_peer_discovery_etcd
And disable those checks in CI for now. We are getting errors because of the eetcd dependency and we can't upgrade at this time (see comment in the commit).
-
make CI: Don't warn about missing CT log files
This can happen if the plugin isn't using CT, or if running Dialyzer, for example.
-
make CI: Disable Elixir problem matchers in tests
They are still enabled in the build job.
-
-
-
-
The fetch-tags option of actions/checkout@v4 does not work as intended so they are fetched manually instead.
-
-
-
make: Set CT_LOGS_DIR to top-level logs/ directory
All CT logs will now be under <toplevel>/logs. An improved test workflow would be to always keep the logs/all_runs.html page open in the browser and refresh it whenever tests are run in any of the rabbit applications.
-
make CI: Use strings instead of numbers for OTP/Ex versions
As recommended by erlef/setup-beam.
-
-
-
Make rabbit_global_counters:overview/0 generally available
Previously it was only available when TEST=1 was set.
-
-
CT: No longer wait 3 minutes for node start
Reverting back to the default 1 minute. The problem with 3 minutes is that this is exceedingly long and when there are problems the test time increases exponentially.
-
-
-
-
Better fix for a Dialyzer warning
The previous fix was leading to a badmatch in some cases, including when trying to stop a node that was already stopped.
