Require all feature flags introduced before 3.11.1 #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
requested changes
Feb 8, 2023
ansd
force-pushed
the
require-feature-flags
branch
from
e2ffa13
to
3da9800
Compare
ansd
force-pushed
the
require-feature-flags
branch
from
3da9800
to
9dc0aa5
Compare
RabbitMQ 3.12 requires feature flag `feature_flags_v2` which got introduced in 3.11.0 (see #6810). Therefore, we can mark all feature flags that got introduced in 3.11.0 or before 3.11.0 as required because users will have to upgrade to 3.11.x first, before upgrading to 3.12.x The advantage of marking these feature flags as required is that we can start deleting any compatibliy code for these feature flags, similarly as done in #5215 This list shows when a given feature flag was first introduced: ``` classic_mirrored_queue_version 3.11.0 stream_single_active_consumer 3.11.0 direct_exchange_routing_v2 3.11.0 listener_records_in_ets 3.11.0 tracking_records_in_ets 3.11.0 empty_basic_get_metric 3.8.10 drop_unroutable_metric 3.8.10 ``` In this commit, we also force all required feature flags in Erlang application `rabbit` to be enabled in mixed version cluster testing and delete any tests that were about a feature flag starting as disabled. Furthermore, this commit already deletes the callback (migration) functions given they do not run anymore in 3.12.x. All other clean up (i.e. branching depending on whether a feature flag is enabled) will be done in separate commits.
ansd
force-pushed
the
require-feature-flags
branch
from
9dc0aa5
to
5045fce
Compare
ansd
added a commit
that referenced
this pull request
Feb 8, 2023
Remove compatibility code for feature flags * drop_unroutable_metric * empty_basic_get_metric since they are required in 3.12.0. See #7219
michaelklishin
approved these changes
Feb 8, 2023
dumbbell
approved these changes
Feb 9, 2023
ansd
added a commit
that referenced
this pull request
Feb 9, 2023
Remove compatibility code for feature flags * drop_unroutable_metric * empty_basic_get_metric since they are required in 3.12.0. See #7219
ansd
added a commit
that referenced
this pull request
Feb 13, 2023
Remove compatibility code for feature flag `stream_single_active_consumer` because this feature flag is `required` in 3.12. See #7219
ansd
added a commit
that referenced
this pull request
Feb 13, 2023
Remove compatibility code for feature flag direct_exchange_routing_v2 because this feature flag is required in 3.12. See #7219
ansd
added a commit
that referenced
this pull request
Feb 13, 2023
Remove compatibility code for feature flag `stream_queue` because this feature flag is required in 3.12. See #7219
ansd
added a commit
that referenced
this pull request
Feb 13, 2023
Remove compatibility code for feature flag `stream_queue` because this feature flag is required in 3.12. See #7219
This was referenced Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ 3.12 requires feature flag
feature_flags_v2which got introduced in 3.11.0 (see #6810).Therefore, we can mark all feature flags that got introduced in 3.11.0
or before 3.11.0 as required because users will have to upgrade to
3.11.x first, before upgrading to 3.12.x
The advantage of marking these feature flags as required is that we can
start deleting any compatibliy code for these feature flags, similarly
as done in #5215
This list shows when a given feature flag was first introduced:
In this commit, we also force all required feature flags in Erlang
application
rabbitto be enabled in mixed version cluster testingand delete any tests that were about a feature flag starting as disabled.
Furthermore, this commit already deletes the callback (migration) functions
given they do not run anymore in 3.12.x.
All other clean up (i.e. branching depending on whether a feature flag
is enabled) will be done in separate commits.