Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility code for management agent feature flags #7223

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

ansd
Copy link
Member

@ansd ansd commented Feb 8, 2023

Remove compatibility code for feature flags

  • drop_unroutable_metric
  • empty_basic_get_metric

since they are required in 3.12.0.

Depends on #7219

@mergify mergify bot added the bazel label Feb 8, 2023
@ansd
Copy link
Member Author

ansd commented Feb 8, 2023

Manually checked that both metrics show up in the Management UI:
Screenshot 2023-02-08 at 18 34 51

Screenshot 2023-02-08 at 18 27 39

@ansd ansd marked this pull request as ready for review February 8, 2023 17:38
@ansd ansd requested a review from dumbbell February 8, 2023 17:39
michaelklishin
michaelklishin previously approved these changes Feb 8, 2023
Remove compatibility code for feature flags
* drop_unroutable_metric
* empty_basic_get_metric

since they are required in 3.12.0.

See #7219
@dumbbell dumbbell merged commit a2858a0 into main Feb 9, 2023
@dumbbell dumbbell deleted the mgmt-agent-ff-compat-code branch February 9, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants