Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [EDXOLDMNG-116] Support for legacy assets with deprecated keys is removed #2468

Conversation

NiedielnitsevIvan
Copy link

Description: Support for legacy assets with deprecated keys is removed

Youtrack: Link to Youtrack ticket

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Documentation in source code updated
  • All related Confluence documentation is updated (including deployment documentation)
  • Commits are squashed

Post merge:

  • Delete working branch (if not needed anymore)

NikolayBorovenskiy and others added 3 commits December 7, 2022 15:05
…signatures to credentials on certificate update (#2464)

* feat: [EDXOLDMNG-218] implements signal handlers for COURSE_CERTIFICATE_CONFIG_DELETED and COURSE_CERTIFICATE_CONFIG_CHANGED to send cert config data onto Credentials service

* feat: [EDXOLDMNG-218] emits course certificate config changed signal when course import happened.

* feat: [EDXOLDMNG-218] Emits emit_course_certificate_config_changed_signal, emit_course_certificate_config_deleted_signal when course config data is changing in Studio UI

* test: [EDXOLDMNG-218] Tests for course certificate configuration signals.

* test: [EDXOLDMNG-218] Adds tests for CertificatesListHandler and CertificatesDetailHandler to be sure that certificate config data signals are emiting

* refactor: [EDXOLDMNG-218] Makes CERTIFICATE_JSON_WITH_SIGNATORIES and HelperMethods are ready to more common usage.

* chore: [EDXOLDMNG-218] Code polishing.

* chore: [EDXOLDMNG-218] temporarily switched to RG code repository for openedx-events package.

* chore: [EDXOLDMNG-218] updates openedx-events to 3.2.0 to testing env.

* style: [EDXOLDMNG-218] deletes unused import

* Nborovenskiy/edxoldmng 224/create a management command to transfer certificate configs to credentials (#2465)

* refactor: [EDXOLDMNG-224] Moves course certificate configuration creation and deletion to separate functions.

* feat: [EDXOLDMNG-218] uses course id instead of course key for CertificateConfigData container

* test: [EDXOLDMNG-224] updates SignalCourseCertificateConfigurationListenerTestCase tests in order refactoring the approach to send data to Credentials via http.

* test: [EDXOLDMNG-224] creates tests for course certificate configuration credentials utils apis.

* feat: [EDXOLDMNG-224] Creates manage.py command to migrate course certificate coniguration.

* refactor: [EDXOLDMNG-224] code polishing for migrate cert config command.

* docs: [EDXOLDMNG-224] adds doc string for migrate_cert_config command's main class
#2466)

* feat: [EDXOLDMNG-236] certificate config for old courses is taken from credentials

* style: [EDXOLDMNG-236] disable pylint issues

* refactor: [EDXOLDMNG-236] refactored the logic for getting the certificate configuration

* refactor: [EDXOLDMNG-236] refactored the logic for getting the certificate configuration

* fix: [EDXOLDMNG-236] remove extra try except
@NiedielnitsevIvan NiedielnitsevIvan force-pushed the Ivan_Niedielnitsev/EDXOLDMNG-116/feature/Alter-AssetManager-to-remove-support-for-deprecated-keys branch from 1796daa to e41c7e7 Compare December 20, 2022 12:33
@NiedielnitsevIvan NiedielnitsevIvan force-pushed the Ivan_Niedielnitsev/EDXOLDMNG-116/feature/Alter-AssetManager-to-remove-support-for-deprecated-keys branch from e41c7e7 to d0ea28b Compare December 20, 2022 12:40
@GlugovGrGlib
Copy link

This PR was taken out of the Old Mongo Depr project

@GlugovGrGlib GlugovGrGlib deleted the Ivan_Niedielnitsev/EDXOLDMNG-116/feature/Alter-AssetManager-to-remove-support-for-deprecated-keys branch December 28, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants