Nborovenskiy/edxoldmng 224/create a management command to transfer certificate configs to credentials #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolayBorovenskiy
force-pushed
the
nborovesnkiy/EDXOLDMNG-218/copy-certificate-configurations-including-signatures-to-credentials-on-certificate-update
branch
from
486e716
to
764b931
Compare
NikolayBorovenskiy
force-pushed
the
nborovenskiy/EDXOLDMNG-224/create-a-management-command-to-transfer-certificate-configs-to-credentials
branch
from
38d7e01
to
b0b7de5
Compare
NikolayBorovenskiy
force-pushed
the
nborovesnkiy/EDXOLDMNG-218/copy-certificate-configurations-including-signatures-to-credentials-on-certificate-update
branch
from
6fea164
to
4801b07
Compare
…tion and deletion to separate functions.
…icateConfigData container
…tenerTestCase tests in order refactoring the approach to send data to Credentials via http.
…ion credentials utils apis.
…tificate coniguration.
NikolayBorovenskiy
force-pushed
the
nborovenskiy/EDXOLDMNG-224/create-a-management-command-to-transfer-certificate-configs-to-credentials
branch
from
b0b7de5
to
3ae9fcf
Compare
| self.user = FakedUser(user_id) | ||
|
|
||
|
|
||
| class Command(BaseCommand): |
There was a problem hiding this comment.
I think should add examples with this command usage.
There was a problem hiding this comment.
done. get a docstign)
| ): | ||
| if certificates := CertificateManager.get_certificates(course): | ||
| for certificate_data in certificates: | ||
| for mode in course_modes: |
There was a problem hiding this comment.
I understand correctly that several identical certificates with different mods can be sent to the Credentials here?
There was a problem hiding this comment.
Yes, each mode that can have a certificate will get a request to Cred.
NikolayBorovenskiy
merged commit dc6eaf4
into
nborovesnkiy/EDXOLDMNG-218/copy-certificate-configurations-including-signatures-to-credentials-on-certificate-update
NikolayBorovenskiy
added a commit
that referenced
this pull request
Dec 7, 2022
…signatures to credentials on certificate update (#2464) * feat: [EDXOLDMNG-218] implements signal handlers for COURSE_CERTIFICATE_CONFIG_DELETED and COURSE_CERTIFICATE_CONFIG_CHANGED to send cert config data onto Credentials service * feat: [EDXOLDMNG-218] emits course certificate config changed signal when course import happened. * feat: [EDXOLDMNG-218] Emits emit_course_certificate_config_changed_signal, emit_course_certificate_config_deleted_signal when course config data is changing in Studio UI * test: [EDXOLDMNG-218] Tests for course certificate configuration signals. * test: [EDXOLDMNG-218] Adds tests for CertificatesListHandler and CertificatesDetailHandler to be sure that certificate config data signals are emiting * refactor: [EDXOLDMNG-218] Makes CERTIFICATE_JSON_WITH_SIGNATORIES and HelperMethods are ready to more common usage. * chore: [EDXOLDMNG-218] Code polishing. * chore: [EDXOLDMNG-218] temporarily switched to RG code repository for openedx-events package. * chore: [EDXOLDMNG-218] updates openedx-events to 3.2.0 to testing env. * style: [EDXOLDMNG-218] deletes unused import * Nborovenskiy/edxoldmng 224/create a management command to transfer certificate configs to credentials (#2465) * refactor: [EDXOLDMNG-224] Moves course certificate configuration creation and deletion to separate functions. * feat: [EDXOLDMNG-218] uses course id instead of course key for CertificateConfigData container * test: [EDXOLDMNG-224] updates SignalCourseCertificateConfigurationListenerTestCase tests in order refactoring the approach to send data to Credentials via http. * test: [EDXOLDMNG-224] creates tests for course certificate configuration credentials utils apis. * feat: [EDXOLDMNG-224] Creates manage.py command to migrate course certificate coniguration. * refactor: [EDXOLDMNG-224] code polishing for migrate cert config command. * docs: [EDXOLDMNG-224] adds doc string for migrate_cert_config command's main class
NikolayBorovenskiy
added a commit
that referenced
this pull request
Dec 14, 2022
…rtificate configs to credentials (#2465) * refactor: [EDXOLDMNG-224] Moves course certificate configuration creation and deletion to separate functions. * feat: [EDXOLDMNG-218] uses course id instead of course key for CertificateConfigData container * test: [EDXOLDMNG-224] updates SignalCourseCertificateConfigurationListenerTestCase tests in order refactoring the approach to send data to Credentials via http. * test: [EDXOLDMNG-224] creates tests for course certificate configuration credentials utils apis. * feat: [EDXOLDMNG-224] Creates manage.py command to migrate course certificate coniguration. * refactor: [EDXOLDMNG-224] code polishing for migrate cert config command. * docs: [EDXOLDMNG-224] adds doc string for migrate_cert_config command's main class
NikolayBorovenskiy
added a commit
that referenced
this pull request
Jan 5, 2023
…rtificate configs to credentials (#2465) * refactor: [EDXOLDMNG-224] Moves course certificate configuration creation and deletion to separate functions. * feat: [EDXOLDMNG-218] uses course id instead of course key for CertificateConfigData container * test: [EDXOLDMNG-224] updates SignalCourseCertificateConfigurationListenerTestCase tests in order refactoring the approach to send data to Credentials via http. * test: [EDXOLDMNG-224] creates tests for course certificate configuration credentials utils apis. * feat: [EDXOLDMNG-224] Creates manage.py command to migrate course certificate coniguration. * refactor: [EDXOLDMNG-224] code polishing for migrate cert config command. * docs: [EDXOLDMNG-224] adds doc string for migrate_cert_config command's main class
GlugovGrGlib
pushed a commit
that referenced
this pull request
Jun 12, 2023
…rtificate configs to credentials (#2465) * refactor: [EDXOLDMNG-224] Moves course certificate configuration creation and deletion to separate functions. * feat: [EDXOLDMNG-218] uses course id instead of course key for CertificateConfigData container * test: [EDXOLDMNG-224] updates SignalCourseCertificateConfigurationListenerTestCase tests in order refactoring the approach to send data to Credentials via http. * test: [EDXOLDMNG-224] creates tests for course certificate configuration credentials utils apis. * feat: [EDXOLDMNG-224] Creates manage.py command to migrate course certificate coniguration. * refactor: [EDXOLDMNG-224] code polishing for migrate cert config command. * docs: [EDXOLDMNG-224] adds doc string for migrate_cert_config command's main class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR is going to implement a management command to transfer certificate configs to credentials.
Youtrack: https://youtrack.raccoongang.com/issue/EDXOLDMNG-224
Testing instructions:
Please call
python manage.py cms migrate_cert_config --helpto see the command capability.Reviewers:
Merge checklist:
Post merge: