Nborovesnkiy/edxoldmng 218/copy certificate configurations including signatures to credentials on certificate update #2464
Conversation
| credentials_api_base_url = get_credentials_api_base_url() | ||
| api_url = urljoin(f'{credentials_api_base_url}/', 'course_certificates/') | ||
| payload = attr.asdict(certificate_config) | ||
| payload['course_key'] = str(payload.pop('course_key')) |
There was a problem hiding this comment.
Yep, fixed here https://github.com/raccoongang/edx-platform/pull/2465/files.
| credentials_api_base_url = get_credentials_api_base_url() | ||
| api_url = urljoin(f'{credentials_api_base_url}/', 'course_certificates/') | ||
| payload = attr.asdict(certificate_config) | ||
| payload['course_key'] = str(payload.pop('course_key')) |
There was a problem hiding this comment.
Change it to course_id pls. Because the API takes the course_id argument by default.
There was a problem hiding this comment.
Agree and I've fixed it already here https://github.com/raccoongang/edx-platform/pull/2465/files. Please look it also. This PR is going to be merged together with the current one.
There was a problem hiding this comment.
It's ok that you pass course_key to CertificateConfigData here, but in RP https://github.com/raccoongang/edx-platform/pull/2465/files you pass course_id?
There was a problem hiding this comment.
Do not understand the question a little bit. There is no already course_key at all. Only we get now course_id. I've changed it everwhere. Please explain what do u mean.)
NikolayBorovenskiy
force-pushed
the
nborovesnkiy/EDXOLDMNG-218/copy-certificate-configurations-including-signatures-to-credentials-on-certificate-update
branch
from
486e716
to
764b931
Compare
|
@NikolayBorovenskiy Main case for failed tests is |
…TE_CONFIG_DELETED and COURSE_CERTIFICATE_CONFIG_CHANGED to send cert config data onto Credentials service
…when course import happened.
…gnal, emit_course_certificate_config_deleted_signal when course config data is changing in Studio UI
…ificatesDetailHandler to be sure that certificate config data signals are emiting
… HelperMethods are ready to more common usage.
… openedx-events package.
NikolayBorovenskiy
force-pushed
the
nborovesnkiy/EDXOLDMNG-218/copy-certificate-configurations-including-signatures-to-credentials-on-certificate-update
branch
from
6fea164
to
4801b07
Compare
…rtificate configs to credentials (#2465) * refactor: [EDXOLDMNG-224] Moves course certificate configuration creation and deletion to separate functions. * feat: [EDXOLDMNG-218] uses course id instead of course key for CertificateConfigData container * test: [EDXOLDMNG-224] updates SignalCourseCertificateConfigurationListenerTestCase tests in order refactoring the approach to send data to Credentials via http. * test: [EDXOLDMNG-224] creates tests for course certificate configuration credentials utils apis. * feat: [EDXOLDMNG-224] Creates manage.py command to migrate course certificate coniguration. * refactor: [EDXOLDMNG-224] code polishing for migrate cert config command. * docs: [EDXOLDMNG-224] adds doc string for migrate_cert_config command's main class
Description: This PR is going to implement the feature Copy certificate configurations including signatures to credentials on certificate update
Youtrack: Link to Youtrack ticket
Configuration instructions: The raccoongang/openedx-events#1 has to be merged first.
Reviewers:
Merge checklist:
Post merge: