Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

[rfr] Adding LBaaS v2 Support #575

Merged
merged 6 commits into from
Jun 1, 2016
Merged

[rfr] Adding LBaaS v2 Support #575

merged 6 commits into from
Jun 1, 2016

Conversation

dagnello
Copy link
Contributor

@dagnello dagnello commented May 15, 2016 •
edited
Loading

This PR includes LBaaS V2 Support for the following components (ref. #460):

  • Loadbalancers
  • Listeners
  • Pools and Members
  • Health Monitors

LbaaS v2 API documentation:
http://developer.openstack.org/api-ref-networking-v2-ext.html
Note: There are some details missing/invalid in current docs, I have been using client calls with --debug flag to see what the API actually returns.

@coveralls
Copy link

coveralls commented May 15, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 80.924% when pulling 6150ff0 on hpcloud:lbaas-v2 into adc2065 on rackspace:master.

@dagnello dagnello force-pushed the lbaas-v2 branch 2 times, most recently from 0da3039 to 5cf21d1 Compare May 15, 2016 23:35
@coveralls
Copy link

coveralls commented May 15, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 80.97% when pulling 5cf21d1 on hpcloud:lbaas-v2 into adc2065 on rackspace:master.

@sputnik13 sputnik13 mentioned this pull request May 16, 2016
Closed
@coveralls
Copy link

coveralls commented May 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 80.97% when pulling 7fc1647 on hpcloud:lbaas-v2 into adc2065 on rackspace:master.

@dagnello dagnello changed the title Adding LBaaS v2 Support [rfr] Adding LBaaS v2 Support May 17, 2016
@coveralls
Copy link

coveralls commented May 17, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 80.97% when pulling 1e56341 on hpcloud:lbaas-v2 into adc2065 on rackspace:master.

@coveralls
Copy link

coveralls commented May 17, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 80.97% when pulling 67effef on hpcloud:lbaas-v2 into adc2065 on rackspace:master.

@dagnello dagnello force-pushed the lbaas-v2 branch 2 times, most recently from 7fc1647 to 8ff5e0e Compare May 17, 2016 17:56
@coveralls
Copy link

coveralls commented May 17, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 80.97% when pulling 8ff5e0e on hpcloud:lbaas-v2 into adc2065 on rackspace:master.

@dagnello
Copy link
Contributor Author

hi @jrperritt, this PR is ready for review.

jamiehannaford
jamiehannaford reviewed May 18, 2016
View reviewed changes
openstack/networking/v2/extensions/lbaas_v2/listeners/requests.go
Marker string `q:"marker"`
SortKey string `q:"sort_key"`
SortDir string `q:"sort_dir"`
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get these query options from? I couldn't find them in the API docs or neutron client

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this based on that the Neutron api support filtering on all top level attributes for a resource:
https://wiki.openstack.org/wiki/Neutron/APIv2-specification#Filtering_and_Column_Selection

@vipulsabhaya
Copy link

@jrperritt do we look good for a merge? This is now blocking some Kubernetes and Terraform work.

@jrperritt
Copy link
Contributor

do we look good for a merge?

Definitely not. At the least there's this: #575 (comment) . Then someone (probably me) will need to review it thoroughly by going through the OpenStack source code to validate the API.

This is now blocking some Kubernetes and Terraform work.

The considerations for merging this PR (and indeed all PRs) are its correctness and consistency with the rest of the library. Larger PRs often take more time to go through the review process

@coveralls
Copy link

coveralls commented May 26, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 80.886% when pulling eab574f on hpcloud:lbaas-v2 into 6fbd243 on rackspace:master.

@coveralls
Copy link

coveralls commented May 26, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 80.887% when pulling 645a55c on hpcloud:lbaas-v2 into 6fbd243 on rackspace:master.

@coveralls
Copy link

coveralls commented May 26, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 80.887% when pulling ec93445 on hpcloud:lbaas-v2 into 6fbd243 on rackspace:master.

@coveralls
Copy link

coveralls commented May 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 80.887% when pulling e230bbf on hpcloud:lbaas-v2 into 6fbd243 on rackspace:master.

@dagnello
Copy link
Contributor Author

@jamiehannaford @jrperritt the remaining comments have been addressed.

@coveralls
Copy link

coveralls commented May 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 80.887% when pulling bb39de2 on hpcloud:lbaas-v2 into 6fbd243 on rackspace:master.

@vipulsabhaya
Copy link

@jrperritt Please review, and let us know of any outstanding issues.

@jamiehannaford jamiehannaford merged commit 67139b9 into rackspace:master Jun 1, 2016
@jamiehannaford
Copy link
Contributor

All tests pass, merging. Thanks for the great work @dagnello 🚀

@dagnello
Copy link
Contributor Author

dagnello commented Jun 1, 2016

@jamiehannaford thank you!

@sputnik13 sputnik13 mentioned this pull request Jun 3, 2016
Merged
@jrperritt jrperritt mentioned this pull request Jun 3, 2016
Closed
@dkalleg dkalleg mentioned this pull request Jun 4, 2016
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Jun 10, 2016
Merge pull request #25987 from hpcloud/openstack-lbaas-v2
cbde2ec 
Automatic merge from submit-queue

LBaaS v2 Support for Openstack Cloud Provider Plugin

Resolves #19774.

This work is based on Gophercloud support for LBaaS v2 currently in review (this will have to merge first):
rackspace/gophercloud#575

These changes includes the addition of a new loadbalancer configuration option:  **LBVersion**.  If this configuration attribute is missing or anything other than "v2", lbaas v1 implementation will be used.
dims pushed a commit to dims/openstack-cloud-controller-manager that referenced this pull request Mar 24, 2017
Merge pull request #25987 from hpcloud/openstack-lbaas-v2
8681baa 
Automatic merge from submit-queue

LBaaS v2 Support for Openstack Cloud Provider Plugin

Resolves #19774.

This work is based on Gophercloud support for LBaaS v2 currently in review (this will have to merge first):
rackspace/gophercloud#575

These changes includes the addition of a new loadbalancer configuration option:  **LBVersion**.  If this configuration attribute is missing or anything other than "v2", lbaas v1 implementation will be used.
dims pushed a commit to dims/openstack-cloud-controller-manager that referenced this pull request Sep 6, 2017
Merge pull request #25987 from hpcloud/openstack-lbaas-v2
f58e768 
Automatic merge from submit-queue

LBaaS v2 Support for Openstack Cloud Provider Plugin

Resolves #19774.

This work is based on Gophercloud support for LBaaS v2 currently in review (this will have to merge first):
rackspace/gophercloud#575

These changes includes the addition of a new loadbalancer configuration option:  **LBVersion**.  If this configuration attribute is missing or anything other than "v2", lbaas v1 implementation will be used.
dims pushed a commit to dims/openstack-cloud-controller-manager that referenced this pull request Jan 13, 2018
Merge pull request #25987 from hpcloud/openstack-lbaas-v2
479144b 
Automatic merge from submit-queue

LBaaS v2 Support for Openstack Cloud Provider Plugin

Resolves #19774.

This work is based on Gophercloud support for LBaaS v2 currently in review (this will have to merge first):
rackspace/gophercloud#575

These changes includes the addition of a new loadbalancer configuration option:  **LBVersion**.  If this configuration attribute is missing or anything other than "v2", lbaas v1 implementation will be used.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dagnello @coveralls @jamiehannaford @jrperritt @anguslees @vipulsabhaya