This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
fixing build constraints for lbaas_v2 fixtures #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build constraints are missing a line after the build constraint as required by https://golang.org/pkg/go/build/, and the fixtures are being pulled in by standard builds, causing test code to be included in the final binary.
|
@jrperritt @jamiehannaford this is related to #575 we really need this fix in order to merge kubernetes/kubernetes#25987 Your help is much appreciated, thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build constraints are missing a line after the build constraint
as required by https://golang.org/pkg/go/build/, and the fixtures
are being pulled in by standard builds, causing test code to be
included in the final binary.