-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push master merges to elemental-operator-ci #100
Conversation
On master merge, push the image also to elemental-operator-ci adding also the latest tag, so it can be tracked by external sources and alwasy use the latest master merge Not that in the case of the elemental-operator we also push the PRs to elemental-operator-ci but those are only used temporarily for e2e testing and latest tag will only track master merges Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
supersedes #98 |
As we no longer push to our repos, there is no need to login. This will make PRs also pass if they are from a fork Signed-off-by: Itxaka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 29.16% 29.16%
=======================================
Files 5 5
Lines 360 360
=======================================
Hits 105 105
Misses 251 251
Partials 4 4 Continue to review full report at Codecov.
|
Im actually thinking of even simplifying more the end2end tests. Instead of building the image on one step and pushing it, then getting it on the next one and making the operator download it we can just do it on one step. Build image, build chart, create cluster, sideload the image into the cluster and run the tests. That allows us to not spend any time pushing the images anywhere for testing. |
crap I forgot the automerge :D |
On master merge, push the image also to elemental-operator-ci adding
also the latest tag, so it can be tracked by external sources and alwasy
use the latest master merge
Not that in the case of the elemental-operator we also push the PRs to
elemental-operator-ci but those are only used temporarily for e2e
testing and latest tag will only track master merges
Signed-off-by: Itxaka [email protected]