Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push master merges to elemental-operator-ci #100

Merged
merged 5 commits into from
Aug 1, 2022
Merged

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Aug 1, 2022

On master merge, push the image also to elemental-operator-ci adding
also the latest tag, so it can be tracked by external sources and alwasy
use the latest master merge

Not that in the case of the elemental-operator we also push the PRs to
elemental-operator-ci but those are only used temporarily for e2e
testing and latest tag will only track master merges

Signed-off-by: Itxaka [email protected]

Itxaka added 2 commits August 1, 2022 11:49
On master merge, push the image also to elemental-operator-ci adding
also the latest tag, so it can be tracked by external sources and alwasy
use the latest master merge

Not that in the case of the elemental-operator we also push the PRs to
elemental-operator-ci but those are only used temporarily for e2e
testing and latest tag will only track master merges

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested review from davidcassany, ldevulder and a team August 1, 2022 10:45
@Itxaka
Copy link
Contributor Author

Itxaka commented Aug 1, 2022

supersedes #98

As we no longer push to our repos, there is no need to login. This will
make PRs also pass if they are from a fork

Signed-off-by: Itxaka <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #100 (7452aed) into main (5f07c44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   29.16%   29.16%           
=======================================
  Files           5        5           
  Lines         360      360           
=======================================
  Hits          105      105           
  Misses        251      251           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f07c44...7452aed. Read the comment docs.

@Itxaka Itxaka enabled auto-merge (squash) August 1, 2022 13:23
@Itxaka
Copy link
Contributor Author

Itxaka commented Aug 1, 2022

Im actually thinking of even simplifying more the end2end tests. Instead of building the image on one step and pushing it, then getting it on the next one and making the operator download it we can just do it on one step. Build image, build chart, create cluster, sideload the image into the cluster and run the tests.

That allows us to not spend any time pushing the images anywhere for testing.

@Itxaka Itxaka merged commit 190a6c0 into main Aug 1, 2022
@Itxaka
Copy link
Contributor Author

Itxaka commented Aug 1, 2022

crap I forgot the automerge :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants