Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push master merges to elemental-operator-ci #98

Closed
wants to merge 1 commit into from

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Aug 1, 2022

On master merge, push the image also to elemental-operator-ci adding
also the latest tag, so it can be tracked by external sources and alwasy
use the latest master merge

Not that in the case of the elemental-operator we also push the PRs to
elemental-operator-ci but those are only used temporarily for e2e
testing and latest tag will only track master merges

Signed-off-by: Itxaka [email protected]

On master merge, push the image also to elemental-operator-ci adding
also the latest tag, so it can be tracked by external sources and alwasy
use the latest master merge

Not that in the case of the elemental-operator we also push the PRs to
elemental-operator-ci but those are only used temporarily for e2e
testing and latest tag will only track master merges

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested review from davidcassany, ldevulder and a team August 1, 2022 09:51
@Itxaka
Copy link
Contributor Author

Itxaka commented Aug 1, 2022

@davidcassany and this is the other part for the same rancher/elemental#227 issue so from elemental main we can track latest for both operator AND elemental-cli and test based on those, catch any issues quickly.

@ldevulder how would you feel if we moved the PRs building images to something more ephemeral like ttl.sh? I wonder if it makes sense to keep those in a repo forever..... after all, they should be up enough time for the testing to complete and can always be rebuilt locally

@ldevulder
Copy link
Contributor

ldevulder commented Aug 1, 2022

@ldevulder how would you feel if we moved the PRs building images to something more ephemeral like ttl.sh? I wonder if it makes sense to keep those in a repo forever..... after all, they should be up enough time for the testing to complete and can always be rebuilt locally

I think it shouldn't be an issue at all, yes doesn't make sense to keep CI build forever. No problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants