Check crds chart is aligned with the main operator chart version #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
validate_crds_chart_version
branch
from
646b00d
to
e8f17ca
Compare
davidcassany
force-pushed
the
validate_crds_chart_version
branch
from
e8f17ca
to
8f6f74c
Compare
davidcassany
force-pushed
the
validate_crds_chart_version
branch
from
8f6f74c
to
897af97
Compare
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
validate_crds_chart_version
branch
from
897af97
to
5b6ba75
Compare
anmazzotti
reviewed
Jun 28, 2024
| @@ -22,5 +22,9 @@ | |||
| {{- if eq $crdrelease $.Release.Name -}} | |||
| {{- required "Elemental CRDs should be moved to the new elemental-operator-crds chart before upgrading this operator." "" -}} | |||
| {{- end -}} | |||
| {{- $crdversion := index $crdobj.metadata.annotations "app.kubernetes.io/version" -}} | |||
| {{- if or (not $crdversion) (ne $crdversion $.Chart.Version) -}} | |||
| {{- required "Elemental Operator CRDs chart version must match the version of this chart. Please install the corresponding CRD chart before." "" -}} | |||
anmazzotti
approved these changes
Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some annotations and labels for the CRDs chart based on https://v2.helm.sh/docs/chart_best_practices/#standard-labels
With them we can add a validation to check CRDs chart and Elemental-Operator chart are aligned with the same version.