Backport to v1.6.x #796
Merged
Backport to v1.6.x #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.6.x #796 +/- ##
=========================================
Coverage ? 57.74%
=========================================
Files ? 42
Lines ? 5180
Branches ? 0
=========================================
Hits ? 2991
Misses ? 1868
Partials ? 321 ☔ View full report in Codecov by Sentry. |
|
The default channel should be added in this PR too. That's the reason for keeping it as a draft |
davidcassany
force-pushed
the
backport_to_v1.6.x
branch
from
9195f38
to
0b133f7
Compare
This commit adds a development channel reference to builds done in OBS (under or branched from isv:Rancher:Elemental) Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 6ee9211)
Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 0f59b14)
* Update channels * Adding a downgrade/upgrade charts e2e test * Only fetch logs for running containers * Do not fail fast in e2e matrix Signed-off-by: David Cassany <[email protected]> (cherry picked from commit d7a712d)
Signed-off-by: Loic Devulder <[email protected]> (cherry picked from commit b866419)
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
backport_to_v1.6.x
branch
from
0b133f7
to
e9f1012
Compare
fgiudici
reviewed
Aug 5, 2024
| {{ if hasPrefix "registry.opensuse.org" .Values.registryUrl }} | ||
| # Unstable channel for isv:Rancher:Elemental OBS projects | ||
| # Unstable channel for testing isv:Rancher:Elemental OBS projects | ||
| # it is only rendered if the registryUrl value includes a known OBS project reference |
There was a problem hiding this comment.
This will be present also on the final released chart, right?
Not 100% happy that we bring this in the final chart. I see it shouldn't harm, but production ready version should be free of the test references IMHO...
Btw, we can drop it in the marketplace later if needed (maybe even the whole channel-dev 🤔 ... for a later discussion 😄 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting changes related to channels