remove versioneer #615
Merged
remove versioneer #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigony
reviewed
Oct 25, 2023
| __version__ = get_versions()['version'] | ||
| del get_versions | ||
| del _version | ||
| __version__ = "23.12.00" |
There was a problem hiding this comment.
Would be better if we could setup a mechanism to update this hard-corded value.
There was a problem hiding this comment.
The update-version.sh is used to do this. Though we may need to update the logic in that script to perform replacement in the right files
There was a problem hiding this comment.
For example rmm's update-version.sh has this line, which we might want to borrow
There was a problem hiding this comment.
Thanks, added this in commit cd1f8fc
raydouglass
approved these changes
Oct 25, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…ect.toml (#616) The first commit here is from #615 This MR makes multiple linting-related changes to cuCIM - moves existing `isort` config from `setup.cfg` to a new `pyproject.toml` file - update `isort` conventions to match other RAPIDS projects - add `black` and apply it (use `fmt::off`/`fmt::on` as needed to preserve formatting of look-up tables and test cases) - replace use of `flake8` with `ruff` - add config for `codespell` and apply recommended fixes across both C++ and Python code - update CONTRIBUTING.md instructions to reflect these changes - Pre-commit hooks for `black`, `ruff` and `codespell` were added. The pre-commit hook for `flake8` was removed. The only non-linting change is - move pytest configuration from `setup.cfg` to `pyproject.toml` I plan to leave any build-system related changes to `pyproject.toml` to a follow-up MR. This MR focuses only on linting/testing. It will probably be easiest to review the individual commits. Some, like applying `black` are quite large. Fixes #23 Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Bradley Dice (https://github.com/bdice) - Ray Douglass (https://github.com/raydouglass) - Gigon Bae (https://github.com/gigony) - https://github.com/jakirkham URL: #616
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
This MR is on top of #615 and #616 so those should be reviewed and merged first. Currently `run build_python_package` will be in a broken state. Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Gigon Bae (https://github.com/gigony) - Ray Douglass (https://github.com/raydouglass) - https://github.com/jakirkham URL: #617
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Contributes to rapidsai/build-planning#31 Removes `.gitattributes` files. These have been here since the beginning of the project (048d53e), for use with `versioneer`. Per the `git` docs ([link](https://git-scm.com/docs/gitattributes#_export_subst)), setting the attribute `export-subst` on a file via a `.gitattributes` tell `git` to replace placeholders in the file with some `git` information. This is no longer done in `_version.py` files in this project, and this project no longer uses `versioneer` (#615). `rapids-build-backend` handles storing git commit information in the published packages. ## Notes for Reviewers For more details, see rapidsai/build-planning#31 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mike Sarahan (https://github.com/msarahan) - Gregory Lee (https://github.com/grlee77) URL: #740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove versioneer to more closely follow RAPIDS conventions