remove .gitattributes #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
msarahan
approved these changes
Jun 18, 2024
|
(edit: I missed that this needs |
grlee77
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Thanks, @jameslamb! Looks like we missed removing this when we moved away from versioneer last year.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#31
Removes
.gitattributesfiles.These have been here since the beginning of the project (048d53e), for use with
versioneer. Per thegitdocs (link), setting the attributeexport-subston a file via a.gitattributestellgitto replace placeholders in the file with somegitinformation.This is no longer done in
_version.pyfiles in this project, and this project no longer usesversioneer(#615).rapids-build-backendhandles storing git commit information in the published packages.Notes for Reviewers
For more details, see rapidsai/build-planning#31 (comment)