Rename CUDA_TRY macro to CUDF_CUDA_TRY, rename CHECK_CUDA macro to CUDF_CHECK_CUDA. #10589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
code quality
improvement
github-actions
bot
added
Java
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10589 +/- ##
================================================
+ Coverage 86.29% 86.31% +0.02%
================================================
Files 140 140
Lines 22255 22255
================================================
+ Hits 19205 19210 +5
+ Misses 3050 3045 -5
Continue to review full report at Codecov.
|
davidwendt
requested changes
Apr 5, 2022
|
|
||
| CHECK_CUDA(stream.value()); | ||
| CUDF_CHECK_CUDA(stream.value()); |
There was a problem hiding this comment.
This one seems unnecessary. The CHECK_CUDA does a cudaStreamSynchronize on the stream.
There was a problem hiding this comment.
I agree with your assessment, good catch.
There was a problem hiding this comment.
The
CHECK_CUDAdoes acudaStreamSynchronizeon the stream.
Only in debug mode.
Co-authored-by: David Wendt <[email protected]>
bdice
commented
Apr 5, 2022
jrhemstad
approved these changes
Apr 5, 2022
jlowe
approved these changes
Apr 5, 2022
bdice
changed the title
davidwendt
approved these changes
Apr 5, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Apr 13, 2022
Following rapidsai/cudf#10589, this PR removes the dependency to `cudf::CUDA_TRY` and introduces `CUSPATIAL_CUDA_TRY`. Contributes to #474 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #516
abellina
added a commit
to abellina/cudf
that referenced
this pull request
Apr 14, 2022
…ro to CUDF_CHECK_CUDA. (rapidsai#10589)" This reverts commit e8d189c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
CUDA_TRYmacro toCUDF_CUDA_TRYto avoid name conflicts with other libraries. Resolves #9660.Similarly,
CHECK_CUDAhas been renamed toCUDF_CHECK_CUDA.