Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CUDA_TRY with CUSPATIAL_CUDA_TRY #516

Merged
merged 4 commits into from
Apr 13, 2022
Merged

Replace CUDA_TRY with CUSPATIAL_CUDA_TRY #516

merged 4 commits into from
Apr 13, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 7, 2022 •
edited
Loading

Following rapidsai/cudf#10589, this PR removes the dependency to cudf::CUDA_TRY and introduces CUSPATIAL_CUDA_TRY.

Contributes to #474

@isVoid isVoid requested a review from a team as a code owner April 7, 2022 23:40
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Apr 7, 2022
@isVoid isVoid added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 7, 2022
@vyasr
Copy link
Contributor

vyasr commented Apr 8, 2022

JFYI, #511 renamed all uses of CUDA_TRY outside of benchmarks to CUDF_CUDA_TRY, so you'll need to update those as well to remove the cudf dependence.

@isVoid
Copy link
Contributor Author

isVoid commented Apr 8, 2022

Ok thanks. I found an extra usage of CUDF_CUDA_TRY.

harrism
harrism approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really all of them? Thought there would be more.

@isVoid
Copy link
Contributor Author

isVoid commented Apr 8, 2022

#511 shows total 3 usage of CUDF_CUDA_TRY. There are 2 more usage of CUDF_CHECK_CUDA which still depends on libcudf. Should we also replace them?

@isVoid
Copy link
Contributor Author

isVoid commented Apr 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c4700e6 into rapidsai:branch-22.06 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isVoid @vyasr @thomcom @harrism