Bifurcate Dependency Lists [skip-gpuci] #11674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been labeled |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
CMake
Codecov ReportBase: 87.47% // Head: 88.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11674 +/- ##
================================================
+ Coverage 87.47% 88.15% +0.67%
================================================
Files 133 133
Lines 21826 22148 +322
================================================
+ Hits 19093 19525 +432
+ Misses 2733 2623 -110
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
github-actions
bot
removed
Python
bdice
commented
Nov 7, 2022
ajschmidt8
approved these changes
Nov 7, 2022
bdice
commented
Nov 7, 2022
bdice
commented
Nov 7, 2022
ajschmidt8
approved these changes
Nov 7, 2022
galipremsagar
approved these changes
Nov 7, 2022
ajschmidt8
reviewed
Nov 8, 2022
ajschmidt8
added a commit
to rapidsai/raft
that referenced
this pull request
Dec 7, 2022
This PR uses the [`rapids-dependency-file-generator`](https://github.com/rapidsai/dependency-file-generator/) to handle sourcing dependencies. Similarly to rapidsai/rmm#1073 and rapidsai/cudf#11674, this PR introduces a GitHub Action that enforces consistency between the new `dependencies.yaml` file and the generated conda environment for developers. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet)
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…nsolidate some dependency lists (#16611) Proposes some additional cleanup in `dependencies.yaml`, for things I noticed while working through #15483. * standardizes the naming of keys in the `files:` section for build dependencies - *`py_build_{project}` = dependencies for the `[build-system]` table* - *`py_rapids_build_{project}` = dependencies for the `[tool.rapids-build-backend]` table* - *this is how it was done over most of the other repos in rapidsai/build-planning#31, it was just missed because `cudf` was one of the first repos to add `rapids-build-backend`* * removes the dependency on building `streamz` from latest source on GitHub - *`custreamz` conda packages and wheels depend on packages for those, not this git dependency* - https://github.com/rapidsai/cudf/blob/2f7d35435db2b5ed9ead96cf43e2a710db5e5e6d/dependencies.yaml#L752-L754 - https://github.com/rapidsai/cudf/blob/2f7d35435db2b5ed9ead96cf43e2a710db5e5e6d/conda/recipes/custreamz/meta.yaml#L45-L47 - *if this is really needed, I don't think it belongs in the `build_python_cudf` set* - *the last commit to `streamz` was 2 years ago (https://github.com/python-streamz/streamz), this doesn't seem like a `rapids-dask-dependency`, try-to-always-test-against-latest, situation to me* - *I'm guessing this is left over from a time before `streamz` was regularly publishing wheels... it's been in `dependencies.yaml` since that file was first introduced here in November 2022 (#11674)* - *the last release, v0.6.4, was made on July 27, 2022. There have been around 20 commits to `master` since then ([history link](https://github.com/python-streamz/streamz/commits/master/)) ... but if `custreamz` really needed those, I'd expect `custreamz` to depend on the version built from GitHub sources. I strongly suspect that that isn't the case.* * removes `build_python_cudf` and `build_python_libcudf` lists in `dependencies.yaml`, in favor of re-using the `depends_on_rmm` and `depends_on_pylibcudf` lists Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #16611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the
rapids-dependency-file-generatorto handle sourcing dependencies. Similar to rapidsai/rmm#1073, this PR introduces a GitHub Action that enforces consistency between the newdependencies.yamlfile and the generated conda environment for developers.Checklist