-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bifurcate Dependency Lists [skip-gpuci] #1073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
changed the title
Bifurcate Dependency Lists
Bifurcate Dependency Lists [skip-gpuci]
Jul 26, 2022
ajschmidt8
added
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Jul 26, 2022
ajschmidt8
force-pushed
the
split-deps
branch
3 times, most recently
from
July 26, 2022 16:39
27a6b41
to
370d8e6
Compare
bdice
reviewed
Jul 29, 2022
Is this really a 22.08 PR? |
Nope, I will re-target this PR for |
ajschmidt8
force-pushed
the
split-deps
branch
4 times, most recently
from
August 16, 2022 14:42
015013c
to
79a082f
Compare
bdice
reviewed
Aug 16, 2022
bdice
reviewed
Sep 2, 2022
bdice
reviewed
Sep 2, 2022
bdice
reviewed
Sep 2, 2022
bdice
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. Thanks @ajschmidt8 for your hard work and many iterations!
raydouglass
approved these changes
Sep 6, 2022
This was referenced Sep 8, 2022
ajschmidt8
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Nov 8, 2022
This PR uses the [`rapids-dependency-file-generator`](https://github.com/rapidsai/dependency-file-generator/) to handle sourcing dependencies. Similar to rapidsai/rmm#1073, this PR introduces a GitHub Action that enforces consistency between the new `dependencies.yaml` file and the generated conda environment for developers. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - GALI PREM SAGAR (https://github.com/galipremsagar)
ajschmidt8
added a commit
to rapidsai/raft
that referenced
this pull request
Dec 7, 2022
This PR uses the [`rapids-dependency-file-generator`](https://github.com/rapidsai/dependency-file-generator/) to handle sourcing dependencies. Similarly to rapidsai/rmm#1073 and rapidsai/cudf#11674, this PR introduces a GitHub Action that enforces consistency between the new `dependencies.yaml` file and the generated conda environment for developers. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conda
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses rapids-dependency-file-generator along with a new
dependencies.yaml
file to bifurcate the existing dependency lists in theconda/environments
directory.rapids-dependency-file-generator
will generateconda
environment files based on the contents of the newdependencies.yaml
file (see rapidsai/dependency-file-generator for more details). There is also a new GitHub Action that runs a shared workflow (which lives here) to ensure that the generated dependency files are up-to-date in each PR. This shared workflow can easily be implemented across other RAPIDS repositories.Why is this PR Needed?
This PR is necessary to support some upcoming changes in CI. We've recently created some new, slimmer CI images (~450MB vs. the current 6.5GB) in anticipation of the move to GitHub Actions. These new images omit the large dependency packages (i.e.
rapids-{build,notebook,doc}-env
) from the rapidsai/integration repository, which will eventually be deprecated and deleted entirely. One of the consequences of removing theintegration
packages from our CI images is that commonly used test dependencies (i.e.pytest
) are no longer included in the CI images by default. Therefore, we need to ensure that each repository has a list of the dependencies that are required to test its respective libraries. A similar list will also be needed in other repositories for JupyterLab Notebook dependencies (which will be utilized in ourruntime
end-user images), but that list does not apply tormm
.Impacts of these Changes
The changes in this PR impact developers and CI as follows:
Developers
Developers should now update the dependencies in the
dependencies.yaml
file instead of the generated dependency files. If they accidentally update the generated dependency files, the new GitHub Action will fail. At this point, the developer will need to installrapids-dependency-file-generator
and run it from the project's root directory. For example:This step can also be implemented as a pre-commit hook.
CI
The new GitHub Action CI process will use the dependencies in the
test
list independencies.yaml
to create a new test environment forrmm
/librmm
in CI. For example:Additional Information
The new GitHub Action will enforce that an
all
environment (under thefiles.all
key) is included in thedependencies.yaml
file and that it includes all of the dependency lists in thedependencies.conda
anddependencies.conda_and_requirements
sections. This is enforced in the shared workflow here. It exists to provide some standardization across the RAPIDS libraries and will eventually replace therapids-{build,notebook,doc}-env
packages in ourdevel
end-user images.