Avoid skbuild 0.17.2 which affected the cmake -DPython_LIBRARY string #13188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
approved these changes
Apr 20, 2023
vyasr
approved these changes
Apr 20, 2023
|
/merge |
ajschmidt8
approved these changes
Apr 20, 2023
raydouglass
pushed a commit
to raydouglass/cudf
that referenced
this pull request
Apr 21, 2023
…rapidsai#13188) We see builds are failing in cuDF, possibly because of a missing `-DPython_LIBRARY` string in the CMake command: https://github.com/rapidsai/cudf/actions/runs/4750812902/jobs/8439338686#step:11:861 This may be a result of the scikit-build release 0.17.2: https://github.com/scikit-build/scikit-build/pull/943/files Authors: - Sevag H (https://github.com/sevagh) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#13188
raydouglass
added a commit
that referenced
this pull request
Apr 21, 2023
…#13188) (#13195) Back ports the fix in #13188 to fix v23.04 builds Authors: - Sevag H (https://github.com/sevagh) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice)
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
May 3, 2023
Wheel builds are failing because of a recent update to scikit-build. See related PR: rapidsai/cudf#13188 Blocks #1259. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1262
|
Is this still necessary with 0.17.5? There were several fixes, the only remaining failure is if user code had a |
|
@henryiii thanks for the ping. I'm not sure. I can test opening a new PR to remove the pinning and see if tests pass. |
|
Testing in #13424 |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
This PR attempts to allow using newer versions of scikit-build again. cf. #13188 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - AJ Schmidt (https://github.com/ajschmidt8) - Lawrence Mitchell (https://github.com/wence-) URL: #13424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see builds are failing in cuDF, possibly because of a missing
-DPython_LIBRARYstring in the CMake command: https://github.com/rapidsai/cudf/actions/runs/4750812902/jobs/8439338686#step:11:861This may be a result of the scikit-build release 0.17.2: https://github.com/scikit-build/scikit-build/pull/943/files