Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow newer scikit-build #13424

Merged
merged 3 commits into from
May 26, 2023
Merged

Allow newer scikit-build #13424

merged 3 commits into from
May 26, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 23, 2023

Description

This PR attempts to allow using newer versions of scikit-build again.

cf. #13188

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 23, 2023
@vyasr vyasr self-assigned this May 23, 2023
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels May 23, 2023
@vyasr vyasr mentioned this pull request May 23, 2023
Merged
@henryiii
Copy link

henryiii commented May 24, 2023 •
edited
Loading

If you'd like to keep this simpler, I can yank those two releases.

Edit: done, see https://pypi.org/project/scikit-build/#history.

@ajschmidt8 ajschmidt8 changed the title Allow newer scikit-build Allow newer scikit-build May 24, 2023
@ajschmidt8 ajschmidt8 changed the title Allow newer scikit-build Allow newer scikit-build May 24, 2023
@vyasr
Copy link
Contributor Author

vyasr commented May 24, 2023

Thanks @henryiii! Looks good to me. I've opened PRs to our other repos as well to verify that they're all working with the latest scikit-build. Assuming they will all pass now.

@vyasr vyasr marked this pull request as ready for review May 24, 2023 19:13
@vyasr vyasr requested review from a team as code owners May 24, 2023 19:13
@vyasr vyasr requested review from wence- and charlesbluca May 24, 2023 19:13
@bdice
Copy link
Contributor

bdice commented May 24, 2023

Yes, just wanted to say thank you for your quick responses with those fixed releases earlier and also for yanking the broken packages @henryiii. 💯

This looks good to me @vyasr, I'll approve.

wence-
wence- approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@wence-
Copy link
Contributor

wence- commented May 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit 90bb887 into rapidsai:branch-23.08 May 26, 2023
@bdice bdice mentioned this pull request May 31, 2023
Merged
3 tasks
@vyasr vyasr deleted the chore/bump_skbuild_pinning branch January 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @henryiii @bdice @wence- @ajschmidt8