Fix decimal -> float cast in ast code #16038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattione-nvidia
added
improvement
mhaseeb123
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
LGTM. Just curious if we can reuse or consolidate the convert_fixed_to_floating at https://github.com/rapidsai/cudf/blob/branch-24.08/cpp/include/cudf/unary.hpp#L80 to avoid code duplication?
Yeah, that's what I wanted to do, but the code is relying on that decltype(static_cast(f)) to SFINAE-out would-be casts like string_view -> double that would otherwise cause compile-time errors. |
bdice
approved these changes
Jun 14, 2024
bdice
reviewed
Jun 14, 2024
Co-authored-by: Bradley Dice <[email protected]>
|
/merge |
3 tasks
vyasr
pushed a commit
to vyasr/cudf
that referenced
this pull request
Jun 26, 2024
Fix decimal -> float cast in ast code that was missed during the earlier code refactoring for making the cast explicit. This closes [issue 16023](rapidsai#16023) Authors: - Paul Mattione (https://github.com/pmattione-nvidia) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - Bradley Dice (https://github.com/bdice) URL: rapidsai#16038
vyasr
pushed a commit
to vyasr/cudf
that referenced
this pull request
Jun 26, 2024
Fix decimal -> float cast in ast code that was missed during the earlier code refactoring for making the cast explicit. This closes [issue 16023](rapidsai#16023) Authors: - Paul Mattione (https://github.com/pmattione-nvidia) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - Bradley Dice (https://github.com/bdice) URL: rapidsai#16038
raydouglass
pushed a commit
that referenced
this pull request
Jul 1, 2024
Backporting #16038 for a patch release. --------- Co-authored-by: Paul Mattione <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix decimal -> float cast in ast code that was missed during the earlier code refactoring for making the cast explicit.
This closes issue 16023
Checklist