Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #16038 to 24.06 #16101

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Backport #16038 to 24.06 #16101

merged 2 commits into from
Jul 1, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 26, 2024 •
edited by raydouglass
Loading

Description

Backporting #16038 for a patch release.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pmattione-nvidia @vyasr
Fix decimal -> float cast in ast code (rapidsai#16038)
f463c64 
Fix decimal -> float cast in ast code that was missed during the earlier code refactoring for making the cast explicit.  

This closes [issue 16023](rapidsai#16023)

Authors:
  - Paul Mattione (https://github.com/pmattione-nvidia)

Approvers:
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#16038
@vyasr vyasr added bug Something isn't working ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround non-breaking Non-breaking change labels Jun 26, 2024
@vyasr vyasr self-assigned this Jun 26, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 26, 2024
@vyasr vyasr marked this pull request as ready for review June 26, 2024 17:09
@vyasr vyasr requested a review from a team as a code owner June 26, 2024 17:09
@vyasr vyasr requested review from hyperbolic2346 and nvdbaranec and removed request for a team June 26, 2024 17:09
This was referenced Jun 26, 2024
Merged
Merged
@raydouglass raydouglass merged commit e412420 into rapidsai:branch-24.06 Jul 1, 2024
70 of 71 checks passed
@vyasr vyasr deleted the hotfix/ast_decimal_cast branch July 1, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @bdice @raydouglass @pmattione-nvidia