[REVIEW] Hide silhouette_score Python binding due to memory issue #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this feature due to memory issues in C++ implementation for anything but modest numbers of samples
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
wphicks
changed the title
|
This is a temporary change due to #3255. This functionality will be restored once the C++ implementation is rewritten in a more memory-friendly way. |
dantegd
requested changes
Dec 4, 2020
There was a problem hiding this comment.
One small comment, and also need to remove the entry from https://github.com/rapidsai/cuml/blob/branch-0.17/docs/source/api.rst so that it doesn't appear in the docs
dantegd
added
4 - Waiting on Author
wphicks
added
4 - Waiting on Reviewer
dantegd
approved these changes
Dec 4, 2020
dantegd
added
6 - Okay to Auto-Merge
and removed
4 - Waiting on Reviewer
wphicks
added
4 - Waiting on Author
JohnZed
requested changes
Dec 4, 2020
Also remove sillhouette_score from api.rst docs
JohnZed
approved these changes
Dec 4, 2020
JohnZed
added
6 - Okay to Auto-Merge
and removed
4 - Waiting on Author
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3258 +/- ##
===============================================
- Coverage 71.49% 71.39% -0.10%
===============================================
Files 206 205 -1
Lines 16648 16612 -36
===============================================
- Hits 11902 11860 -42
- Misses 4746 4752 +6
Continue to review full report at Codecov.
|
divyegala
added a commit
to divyegala/cuml
that referenced
this pull request
Jan 12, 2021
…ssue (rapidsai#3258)" This reverts commit 40b089b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove silhouette_score Python binding due to memory issues when handling more than a modest number of samples