Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Hide silhouette_score Python binding due to memory issue #3258

Merged
merged 8 commits into from
Dec 5, 2020
Merged

[REVIEW] Hide silhouette_score Python binding due to memory issue #3258

merged 8 commits into from
Dec 5, 2020

Commits on Dec 4, 2020

  1. Hide silhouette_score Python binding 

    Remove this feature due to memory issues in C++ implementation for
anything but modest numbers of samples
    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    7c38be2 View commit details
    Browse the repository at this point in the history

  2. Remove silhouette_score tests

    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    98b953d View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    4a68c2e View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    750f19f View commit details
    Browse the repository at this point in the history

  5. Remove silhouette_score from new features list

    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    323310b View commit details
    Browse the repository at this point in the history

  6. Add note on reason for hiding silhouette_score

    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    da06c18 View commit details
    Browse the repository at this point in the history

  7. Update docstrings with silhouette_score warning 

    Also remove sillhouette_score from api.rst docs
    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    10787dd View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG to restore reference to reverted PR

    @wphicks
    wphicks committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    9b3e8c3 View commit details
    Browse the repository at this point in the history