Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to UCX-Py 0.24 #4396

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Update to UCX-Py 0.24 #4396

merged 1 commit into from
Dec 4, 2021

Conversation

pentschev
Copy link
Member

No description provided.

@pentschev pentschev requested a review from a team as a code owner November 22, 2021 14:31
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Nov 22, 2021
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 22, 2021
@pentschev
Copy link
Member Author

rerun tests

1 similar comment
@pentschev
Copy link
Member Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Nov 23, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Nov 23, 2021

Failure should be fixed with the latest libcumlprims main nightly package

@dantegd
Copy link
Member

dantegd commented Nov 23, 2021

rerun tests

@jakirkham
Copy link
Member

jakirkham commented Nov 30, 2021 •
edited
Loading

This is waiting on PR ( #4400 ). Also this may be superseded by PR ( #4411 )

cc @dantegd (please feel free to correct me/add additional context)

cc @charlesbluca (as this came up in offline discussion)

@charlesbluca charlesbluca mentioned this pull request Nov 30, 2021
Merged
@charlesbluca
Copy link
Member

Thanks for the summary @jakirkham 🙂 for some additional context, this came up on my end when we tried to add cuML to dask-sql's gpuCI images (which also contain ucx-py==0.24) in rapidsai/dask-build-environment#16.

We will revert that PR for now and revisit once this is resolved

@jjacobelli
Copy link
Contributor

This is waiting on PR ( #4400 ). Also this may be superseded by PR ( #4411 )

Note that #4411 will not update the dev environments

@dantegd
Copy link
Member

dantegd commented Dec 3, 2021

rerun tests

1 similar comment
@dantegd
Copy link
Member

dantegd commented Dec 4, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@debeee0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4396   +/-   ##
===============================================
  Coverage                ?   85.72%           
===============================================
  Files                   ?      236           
  Lines                   ?    19306           
  Branches                ?        0           
===============================================
  Hits                    ?    16550           
  Misses                  ?     2756           
  Partials                ?        0
Flag Coverage Δ
dask 46.53% <0.00%> (?)
non-dask 78.61% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debeee0...9b2e135. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Dec 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 70aface into rapidsai:branch-22.02 Dec 4, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@pentschev
Update to UCX-Py 0.24 (rapidsai#4396)
828f996 
Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4396
@pentschev pentschev deleted the update-ucx-py-0.24 branch May 20, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pentschev @dantegd @jakirkham @charlesbluca @jjacobelli @codecov-commenter @ajschmidt8