Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Project Flash to build cuml python package for CUDA 11.0 job #4400

Merged
merged 17 commits into from
Dec 1, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Nov 23, 2021

PR uses project flash to build the cuML Python package mirroring what the C++ flow looks like.

Note: Currently only changed for the CUDA 11.0 GPU test since that one uses Python 3.7, to do the other jobs we need to build the python package twice on the CPU job.

@github-actions github-actions bot added the gpuCI gpuCI issue label Nov 23, 2021
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Nov 23, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 23, 2021
@github-actions github-actions bot added the conda conda issue label Nov 24, 2021
@dantegd dantegd changed the title DBG Debugging CI/libcusolver DBG Debugging CI/libcusolver [skip-ci] Nov 24, 2021
@github-actions github-actions bot removed the conda conda issue label Nov 24, 2021
@dantegd dantegd changed the title DBG Debugging CI/libcusolver [skip-ci] DBG Debugging CI/libcusolver Nov 24, 2021
@dantegd dantegd marked this pull request as ready for review November 29, 2021 13:25
@dantegd dantegd requested review from a team as code owners November 29, 2021 13:25
@github-actions github-actions bot removed the Cython / Python Cython or Python issue label Nov 29, 2021
@dantegd dantegd changed the title DBG Debugging CI/libcusolver Use Project Flash to build cuml python package for CUDA 11.0 job Nov 29, 2021
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for python-codeowners, though I don't see any python files in the changes.

@codecov-commenter
Copy link

Codecov Report

Merging #4400 (cf31cc0) into branch-21.12 (2854a86) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.12    #4400   +/-   ##
=============================================
  Coverage         85.72%   85.72%           
=============================================
  Files               236      236           
  Lines             19306    19306           
=============================================
  Hits              16550    16550           
  Misses             2756     2756           
Flag Coverage Δ
dask 46.53% <ø> (ø)
non-dask 78.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2854a86...cf31cc0. Read the comment docs.

@jakirkham jakirkham mentioned this pull request Nov 30, 2021
@ajschmidt8 ajschmidt8 merged commit e9fb48c into rapidsai:branch-21.12 Dec 1, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…idsai#4400)

PR uses project flash to build the cuML Python package mirroring what the C++ flow looks like.

Note: Currently only changed for the CUDA 11.0 GPU test since that one uses Python 3.7, to do the other jobs we need to build the python package twice on the CPU job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpuCI gpuCI issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants