Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin hdbscan to fix pytests in CI #5515

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Pin hdbscan to fix pytests in CI #5515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies:
- gmock>=1.13.0
- graphviz
- gtest>=1.13.0
- hdbscan
- hdbscan<=0.8.30
- hypothesis>=6.0,<7
- ipykernel
- ipython
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-120_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies:
- gmock>=1.13.0
- graphviz
- gtest>=1.13.0
- hdbscan
- hdbscan<=0.8.30
- hypothesis>=6.0,<7
- ipykernel
- ipython
Expand Down
7 changes: 3 additions & 4 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,10 +348,9 @@ dependencies:
# TODO: Figure out what to do with this dependency
# since the repo is now archived.
- git+https://github.com/dask/dask-glm@main
# TODO: The conda-forge package is being generated from Leland's fork
# (https://github.com/lmcinnes/hdbscan) which is far behind now. Do
# we need to have that updated?
- hdbscan
# TODO: remove pin once a release that includes fixes for the error
# is released: https://github.com/rapidsai/cuml/issues/5514
- hdbscan<=0.8.30
Comment on lines +351 to +353
Copy link
Contributor

@bdice bdice Jul 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't fix the pinnings on pyproject, see just below here where it's pulling from git.

This pinning should move up, to the - output_types: [conda, requirements, pyproject] section. This package is now available on both conda-forge and PyPI, so we don't need a separate conda and pyproject pinning for it. Define this in the previous section (rather than only for conda) and delete the git pinning for pyproject below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If wheel CI is working fine and the only failures are in conda CI, please merge as-is and then make a second PR to unify the pinnings as I suggested above.

Getting CI unblocked before burndown is top priority.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, will address it in an immediate follow up PR

- output_types: pyproject
packages:
- dask-glm @ git+https://github.com/dask/dask-glm@main
Expand Down