Pin hdbscan to fix pytests in CI #5515
Conversation
| # TODO: remove pin once a release that includes fixes for the error | ||
| # is released: https://github.com/rapidsai/cuml/issues/5514 | ||
| - hdbscan<=0.8.30 |
There was a problem hiding this comment.
This won't fix the pinnings on pyproject, see just below here where it's pulling from git.
This pinning should move up, to the - output_types: [conda, requirements, pyproject] section. This package is now available on both conda-forge and PyPI, so we don't need a separate conda and pyproject pinning for it. Define this in the previous section (rather than only for conda) and delete the git pinning for pyproject below.
There was a problem hiding this comment.
If wheel CI is working fine and the only failures are in conda CI, please merge as-is and then make a second PR to unify the pinnings as I suggested above.
Getting CI unblocked before burndown is top priority.
There was a problem hiding this comment.
Yup, will address it in an immediate follow up PR
|
/merge |
|
I merged this to unblock my PRs targeting 23.08. It seems like this is a good fix, thanks @dantegd! |
See issue #5514 for description