reduce hard-coding of version #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
changed the title
RAMitchell
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #115.
Proposes single-sourcing the version for this project in a text file,
VERSION, at the root of the repo. This practice has been very helpful in other RAPIDS libraries, to ensure that versions are consistent across a variety of locations, including:And there's already such an inconsistency here in
legate-boost.legate-boost/pyproject.toml
Line 12 in f58dbe8
legate-boost/CMakeLists.txt
Line 3 in f58dbe8
For more discussion on this practice, see rapidsai/build-planning#15. Thanks to @KyleFromNVIDIA for pushing changes like this across RAPIDS... I've borrowed a lot from his PRs for this one.
Notes for Reviewers
Why v0.1.0?
I know @RAMitchell and I had talked previously about using a calver version that matches
legate-core(e.g.,legate-boost=24.06.00would depend onlegate-core=24.06.00andcunumeric=24.06.00).Proposing we defer that in a follow-up PR, alongside setting up versioning + publishing of nightlies. Keeping the version at 0.1 here means any calendar-based version we add in the future will end up being newer than any packages published from now until then.