-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add legate-boost conda packages #115
Comments
After merging #176, I just did the following to check the code paths for stable releases. Pushed a new release tag like this: git checkout main
git pull upstream main
git tag -a v24.08.00 -m 'v24.08.00'
git push upstream 'v24.08.00' That triggered this build: https://github.com/rapidsai/legate-boost/actions/runs/11616162673 The build succeeded, and it uploaded a ref: https://anaconda.org/legate/legate-boost/files Created an environment and ran the tests. docker run \
--rm \
--gpus "2,3" \
-v $(pwd):/opt/work \
-w /opt/work \
-it rapidsai/ci-conda \
bash
# --override-channels just to be sure we're not cheating with channels
# configured globally in the env where I ran this
conda create \
--name test-legate-boost \
--yes \
--override-channels \
-c legate \
-c legate/label/experimental \
-c conda-forge \
legate-boost=24.08 \
python=3.11 output of 'conda env export --name test-legate-boost (click me)
(NOTICE: I'm on a system with CUDA, and it pulled in the Then installed test dependencies and ran source activate test-legate-boost
conda install \
-c conda-forge \
--yes \
'hypothesis>=6' \
'matplotlib>=3.9' \
'nbconvert>=7.16' \
'notebook>=7' \
'pytest>=7,<8' \
'seaborn>=0.13' \
'xgboost>=2.0'
./ci/run_pytests_gpu.sh Those failed with fatal errors 😭
Will look into it. |
I missed the "Failed to allocate GPU memory" before! Looked at Re-ran with smaller memory requirements and saw the tests pass. This is working 😎 |
The docs deployment failed on that tag build: https://github.com/rapidsai/legate-boost/actions/runs/11616162673/job/32349185474 Like this:
I've asked ops to help take a look. |
Alright ops fixed the docs builds... the issue was just that deploy-github-pags-on-new-tags was not turned on in the repo settings. I pushed another tag ( https://github.com/rapidsai/legate-boost/actions/runs/11619624304/job/32360219823 ... but with the wrong version Put up #177 to fix that. |
Alright, trying this again 😂 Merged #177, saw that successfully build packages and deploy docs: https://github.com/rapidsai/legate-boost/actions/runs/11632125999 I just pushed another tag, like this: git checkout main
git pull upstream main
git tag -a v24.08.02 -m 'v24.08.02'
git push upstream 'v24.08.02' That triggered this build: https://github.com/rapidsai/legate-boost/actions/runs/11632477453 Hopefully, we'll see all the CI jobs succeed and docs published with the correct version ( |
grrrr why did that not work. The deployment says it succeeded: https://github.com/rapidsai/legate-boost/actions/runs/11632477453/job/32396301167 And I can see the docs-building job installed the version we wanted.
But the docs still have the wrong version in them (yes I cleared my browser cache): My next theory was "ok, maybe the wrong artifact is being pulled". Checked the logs from the build job:
Compared that to the deploy job:
Those IDs exactly match. |
I clicked on the https://github.com/rapidsai/legate-boost/actions/runs/11632477453/artifacts/2133838991 And opened it up locally (it's |
I just merged #178, which triggered this build: https://github.com/rapidsai/legate-boost/actions/runs/11673382407/workflow ... it failed again with workflow syntax errors 🙃
I'll put up another PR fixing that, and testing the syntax directly on the PR. Sorry for all the noise getting this last part working 😭 |
Description
For #101 , we want to publish
legate-boost
conda packages to thelegate
channel (https://anaconda.org/legate/repo).This captures the work to do that.
Benefits of this work
legate-boost
Acceptance Criteria
legate-boost
(with the-
)legate
conda channelApproach
Patterns that might be borrowed from RAPIDS libraries, including:
pyproject.toml
instead ofsetup.py
scikit-build-core
as a build backend instead ofscikit-build
rapids-cmake
to manage dependenciesrapids-dependency-file-generator
to keep different lists of dependencies consistentFor an example of this, see how
cuvs
conda packages are built:Notes
legate-core
source, for reference: https://github.com/nv-legate/legate.coreThe text was updated successfully, but these errors were encountered: