Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move more testing logic into scripts #139

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

jameslamb
Copy link
Member

Contributes to #115.

Some testing details like how to run mypy and pytest are currently repeated across CI configuration and the documentation. Once conda builds and corresponding tests are added, there will be even more CI jobs that need to run those same commands.

To reduce duplication and unnecessary differences between the way tests are run locally vs. in CI, this proposes moving that logic into scripts in the ci/ directory.

Notes for Reviewers

These script names follow conventions in use across RAPIDS, which are roughly like this:

  • ci/run_pytests*.sh = run tests, without any reliance on CI-specific details (intended to be usable in local development)
  • ci/test_*.sh = invoke ci/run_pytests*.sh, but maybe with other CI-specific details such as creating a dedicated conda environment

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 12, 2024
@jameslamb jameslamb changed the title WIP: move more testing logic into scripts move more testing logic into scripts Aug 12, 2024
@jameslamb jameslamb marked this pull request as ready for review August 12, 2024 14:45
@jameslamb jameslamb merged commit 63851d7 into rapidsai:main Aug 12, 2024
3 checks passed
@jameslamb jameslamb deleted the ci/mypy-script branch August 12, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants