move more testing logic into scripts #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #115.
Some testing details like how to run
mypy
andpytest
are currently repeated across CI configuration and the documentation. Once conda builds and corresponding tests are added, there will be even more CI jobs that need to run those same commands.To reduce duplication and unnecessary differences between the way tests are run locally vs. in CI, this proposes moving that logic into scripts in the
ci/
directory.Notes for Reviewers
These script names follow conventions in use across RAPIDS, which are roughly like this:
ci/run_pytests*.sh
= run tests, without any reliance on CI-specific details (intended to be usable in local development)ci/test_*.sh
= invokeci/run_pytests*.sh
, but maybe with other CI-specific details such as creating a dedicated conda environment