Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update some CI versions, move docs-building to a script #146

Merged
merged 2 commits into from
Aug 20, 2024
Merged

update some CI versions, move docs-building to a script #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e989b9c
update some CI versions, move docs-building to a script
jameslamb Aug 16, 2024
88249d8
revert name change, to not affect branch protections
jameslamb Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/github-actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
push:
branches:
- "pull-request/[0-9]+"
- "branch-*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo doesn't current use any branch-* branches. I suspect this was maybe copied from somewhere else in RAPIDS. Removing it to simplify configuration a bit.

- "main"

jobs:

# group together all jobs that must pass for a PR to be merged
Expand Down Expand Up @@ -87,17 +87,12 @@ jobs:
run: |
ci/run_pytests_gpu.sh
- name: Build legate-boost docs
working-directory: docs
run: |
apt-get update
apt-get install --no-install-recommends -y \
make
make html
ci/build_docs.sh
- uses: actions/upload-pages-artifact@v3
with:
path: docs/build/html


deploy:
needs: build-test
# only main branch uploads docs
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ repos:
hooks:
- id: isort
- repo: https://github.com/psf/black
rev: '24.4.2'
rev: '24.8.0'
hooks:
- id: black
- repo: https://github.com/PyCQA/flake8
rev: '7.1.0'
rev: '7.1.1'
hooks:
- id: flake8
- repo: https://github.com/PyCQA/docformatter
Expand Down
7 changes: 7 additions & 0 deletions ci/build_docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash

set -e -E -u -o pipefail

rapids-print-env

make -C docs html
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is pretty thin right now, but it'll have more added to it in #129. See the diff there for details.

Publishing a CPU-only conda package will allow us to run docs builds on a machine that doesn't have a GPU 😁

3 changes: 2 additions & 1 deletion conda/environments/all_cuda-122.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies:
- legate-core=24.06=*_ucx
- legate-core==24.06.*
- libcublas-dev
- make
- matplotlib
- mypy
- myst-parser
Expand All @@ -25,7 +26,7 @@ dependencies:
- pydata-sphinx-theme
- pytest<8
- python-build>=1.2.0
- python=3.11
- python=3.12
- scikit-build>=0.18.0
- scikit-learn
- seaborn
Expand Down
19 changes: 16 additions & 3 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ files:
table: build-system
includes:
- build
py_docs:
output: none
includes:
- docs
- py_version
- run
py_run:
output: pyproject
pyproject_dir: .
Expand Down Expand Up @@ -77,9 +83,12 @@ dependencies:
common:
- output_types: [conda, pyproject, requirements]
packages:
- sphinx
- pydata-sphinx-theme
- myst-parser
- pydata-sphinx-theme
- sphinx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just showing up in the diff because I wanted this list to be alphabetized.

- output_types: [conda]
packages:
- make
py_version:
specific:
- output_types: conda
Expand All @@ -99,7 +108,11 @@ dependencies:
- matrix:
py: "3.11"
packages:
- &latest_python python=3.11
- python=3.11
- matrix:
py: "3.12"
packages:
- &latest_python python=3.12
- matrix:
packages:
- *latest_python
Expand Down