Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some CI versions, move docs-building to a script #146

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

jameslamb
Copy link
Member

Contributes to #115

This PR has some miscellaneous small CI things that I noticed while working on adding conda builds in #129. Pulling them into a separate PR to make the diff for that PR smaller.

  • adding a Python 3.12 entry to dependencies.yaml
  • updating all pre-commit hooks (via pre-commit autoupdate)
  • moving docs-building code out of CI configs and into a script

Notes for Reviewers

See comments on the diff for reasoning behind other specific changes.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 16, 2024
@@ -8,8 +8,8 @@ on:
push:
branches:
- "pull-request/[0-9]+"
- "branch-*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo doesn't current use any branch-* branches. I suspect this was maybe copied from somewhere else in RAPIDS. Removing it to simplify configuration a bit.


rapids-print-env

make -C docs html
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is pretty thin right now, but it'll have more added to it in #129. See the diff there for details.

Publishing a CPU-only conda package will allow us to run docs builds on a machine that doesn't have a GPU 😁

- myst-parser
- pydata-sphinx-theme
- sphinx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just showing up in the diff because I wanted this list to be alphabetized.

@jameslamb jameslamb changed the title WIP: update some CI versions, move docs-building to a script update some CI versions, move docs-building to a script Aug 19, 2024
@jameslamb jameslamb marked this pull request as ready for review August 19, 2024 01:37
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Unrelated: I'm still not quite sold on the idea of pre-commit hook, feels like an elaborate effort to have yet another dependency manager for a simple task. But I might be biased.

@jameslamb
Copy link
Member Author

I'm still not quite sold on the idea of pre-commit hook, feels like an elaborate effort to have yet another dependency manager for a simple task

Thanks for this. I felt this way for a long time... working on RAPIDS is the first time I've ever really used pre-commit.

Since I've gotten used to it on RAPIDS repos, I've found it convenient and powerful, relative to every repo having its own slightly different shell scripts or Makefile targets.

For what it's worth, I don't actually use the git functionality at all... I never pre-commit install to make it run as a git hook. I just use this tool to run all static analysis and autoformatting over all files, like pre-commit run --all-files.

@jameslamb jameslamb merged commit b9000ce into rapidsai:main Aug 20, 2024
5 checks passed
@jameslamb jameslamb deleted the docs-env branch August 20, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants