-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update some CI versions, move docs-building to a script #146
Conversation
@@ -8,8 +8,8 @@ on: | |||
push: | |||
branches: | |||
- "pull-request/[0-9]+" | |||
- "branch-*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo doesn't current use any branch-*
branches. I suspect this was maybe copied from somewhere else in RAPIDS. Removing it to simplify configuration a bit.
|
||
rapids-print-env | ||
|
||
make -C docs html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is pretty thin right now, but it'll have more added to it in #129. See the diff there for details.
Publishing a CPU-only conda package will allow us to run docs builds on a machine that doesn't have a GPU 😁
- myst-parser | ||
- pydata-sphinx-theme | ||
- sphinx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just showing up in the diff because I wanted this list to be alphabetized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Unrelated: I'm still not quite sold on the idea of pre-commit hook, feels like an elaborate effort to have yet another dependency manager for a simple task. But I might be biased.
Thanks for this. I felt this way for a long time... working on RAPIDS is the first time I've ever really used Since I've gotten used to it on RAPIDS repos, I've found it convenient and powerful, relative to every repo having its own slightly different shell scripts or Makefile targets. For what it's worth, I don't actually use the |
Contributes to #115
This PR has some miscellaneous small CI things that I noticed while working on adding conda builds in #129. Pulling them into a separate PR to make the diff for that PR smaller.
dependencies.yaml
pre-commit
hooks (viapre-commit autoupdate
)Notes for Reviewers
See comments on the diff for reasoning behind other specific changes.