Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to specific version in test and docs builds #177

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

jameslamb
Copy link
Member

Contributes to #115

To test the release workflow, I did this kind of weird thing where. I pushed a tag v24.08.00 when there was already an "earlier" tag v24.09.00.dev in the repo.

That all worked fine... but pulled in the wrong version in the docs build. Because legate-boost is unpinned here:

rapids-mamba-retry install \
--name docs-env \
--override-channels \
--channel "${RAPIDS_LOCAL_CONDA_CHANNEL}" \
--channel legate \
--channel legate/label/experimental \
--channel conda-forge \
"legate-boost=*=*_cpu*"

conda chose one with the highest version. That was 24.09.00.dev3, even for a workflow run that had produced 24.08.00. Oops.

This fixes that.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 31, 2024
ci/build_docs.sh Outdated
@@ -34,7 +36,7 @@ rapids-mamba-retry install \
--channel legate \
--channel legate/label/experimental \
--channel conda-forge \
"legate-boost=*=*_cpu*"
"legate-boost=${LEGATEBOOST_VERSION}=*_cpu*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is choking on the version:

Looking for: ['legate-boost==24.09.00[build=*_cpu*]']
<snip>
The following package could not be installed
└─ legate-boost 24.09.00 *_cpu* does not exist (perhaps a typo or a missing channel).

But I don't really see why this is different from the tests. I guess we don't need the =*_cpu*, but does it make it not find dev versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need the =_cpu, but does it make it not find dev versions?

I think you're right! That == makes me thing that maybe conda is looking for exactly 24.09.00 (no dev versions or other modifiers).

I think that removing it might allow it to float.

I've also put us into a weird position for testing here by pushing tags to the repo like v24.08.00 that result in new packages having lower versions than older packages (v24.09.00.dev{n}), which is not something that's likely to happen during normal development. I was just trying to be careful in case we weren't able to delete packages from the legate channel, but I'm afraid I might have just made this more complicated than it needed to be 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed the following changes:

  • remove *_cpu* tag in this script
  • run rapids-generate-version first, to update the VERSION file from git tags

Those two together should hopefully fix this.

And once we get this all working, I can put up similar changes in legate-dataframe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just deleted those v24.08.00 / v24.08.01 tags and re-triggered CI here. I think the changes in this PR will be enough to get this working on pushes to main (which I'll test after we merge this).

@jameslamb jameslamb merged commit f0f5ac0 into rapidsai:main Nov 1, 2024
9 checks passed
@jameslamb jameslamb deleted the fix-docs-version branch November 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants