Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

char: silabs: si446x (SiLabs Si446x Transceiver) driver added. #4430

Closed
wants to merge 3 commits into from
Closed

char: silabs: si446x (SiLabs Si446x Transceiver) driver added. #4430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1c1f39
Added overlay for Si446x Transceiver SPI driver
sunipkm Jul 4, 2021
e8af15f
Fixed typo on si446x README entry
sunipkm Jul 4, 2021
8611d60
Fixed overlay compatible target and override byte offset, formatted R…
sunipkm Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arch/arm/boot/dts/overlays/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ dtbo-$(CONFIG_ARCH_BCM2835) += \
seeed-can-fd-hat-v1.dtbo \
seeed-can-fd-hat-v2.dtbo \
sh1106-spi.dtbo \
si446x-spi0.dtbo \
smi.dtbo \
smi-dev.dtbo \
smi-nand.dtbo \
Expand Down
6 changes: 6 additions & 0 deletions arch/arm/boot/dts/overlays/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2720,6 +2720,12 @@ Params: speed SPI bus speed (default 4000000)
reset_pin GPIO pin for RESET (default 25)
height Display height (32 or 64; default 64)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two blank lines between overlays, please.

Name: si446x-spi0
Info: Overlay for Si446x UHF Transceiver via SPI using si446x driver (currently out-of-tree at https://github.com/sunipkmukherjee/silabs.git)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is far too long - there is a hard limit of 80 characters in this file.

Loat: dtoverlay=si446x-spi0,<param>=<val>
Params: speed SPI bus speed (default 4000000)
int_pin GPIO pin for interrupts (default 17)
reset_pin GPIO pin for RESET (default 27)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another blank line here.

Name: smi
Info: Enables the Secondary Memory Interface peripheral. Uses GPIOs 2-25!
Expand Down
53 changes: 53 additions & 0 deletions arch/arm/boot/dts/overlays/si446x-spi0-overlay.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Overlay for the SiLabs Si446X Controller - SPI0
// Default Interrupt Pin: 17
// Default SDN Pin: 27
/dts-v1/;
/plugin/;

/ {
compatible = "brcm,bcm2708";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "brcm,bcm2835".


fragment@0 {
target = <&spi0>;
__overlay__ {
// needed to avoid dtc warning
#address-cells = <1>;
#size-cells = <0>;

status = "okay";

uhf0: si446x@0{
compatible = "silabs,si446x";
reg = <0>; // CE0
pinctrl-names = "default";
pinctrl-0 = <&uhf0_pins>;
interrupt-parent = <&gpio>;
interrupts = <17 0x2>; // falling edge
spi-max-frequency = <4000000>;
sdn_pin = <27>;
irq_pin = <17>;
status = "okay";
};
};
};

fragment@1 {
target = <&gpio>;
__overlay__ {
uhf0_pins: uhf0_pins {
brcm,pins = <17 27>;
brcm,function = <0 1>; // in, out
brcm,pull = <2 0>; // high, none
};
};
};

__overrides__ {
int_pin = <&uhf0>, "interrupts:0",
<&uhf0>, "irq_pin:0",
<&uhf0_pins>, "brcm,pins:0";
reset_pin = <&uhf0>, "sdn_pin:0",
<&uhf0_pins>, "brcm,pins:1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The offset for a parameter target is in bytes - this should say "brcm,pins:4".

speed = <&uhf0>, "spi-max-frequency:0";
};
};