char: silabs: si446x (SiLabs Si446x Transceiver) driver added. #4430

sunipkm · 2021-07-04T08:19:42Z

Implements basic API calls over ioctl, and receive/transmit using read/write. Reads can be non-blocking with polling support. Writes are blocking. Overlay si446x-spi0 provided.
The device is initialized by an userspace program that requires inclusion of the radio configuration generated by the WDS tool from SiLabs, and patched following Zak Kemble's guide (https://blog.zakkemble.net/si4463-radio-library-avr-arduino/).

pelwell · 2021-07-04T09:22:39Z

I'll accept the overlay (with an appropriate README entry), but the driver needs to be submitted upstream to the Linux kernel maintainers.

sunipkm · 2021-07-04T20:07:20Z

I have removed the driver, and updated the README for the overlay as requested.

pelwell

There are a few small issues with the overlay and README entry that I've commented on, but the real problem with this PR is that without the driver people can't use it, and if they're building their own kernel/module they might as well build the overlay with it.

pelwell · 2021-07-05T07:46:56Z

arch/arm/boot/dts/overlays/README

@@ -2720,6 +2720,12 @@ Params: speed                   SPI bus speed (default 4000000)
        reset_pin               GPIO pin for RESET (default 25)
        height                  Display height (32 or 64; default 64)



Two blank lines between overlays, please.

pelwell · 2021-07-05T07:47:18Z

arch/arm/boot/dts/overlays/README

+Load:   dtoverlay=si446x-spi0,<param>=<val>
+Params: speed                   SPI bus speed (default 4000000)
+        int_pin                 GPIO pin for interrupts (default 17)
+        reset_pin               GPIO pin for RESET (default 27)



Another blank line here.

pelwell · 2021-07-05T13:42:37Z

arch/arm/boot/dts/overlays/README

@@ -2720,6 +2720,12 @@ Params: speed                   SPI bus speed (default 4000000)
        reset_pin               GPIO pin for RESET (default 25)
        height                  Display height (32 or 64; default 64)

+Name:   si446x-spi0
+Info:   Overlay for Si446x UHF Transceiver via SPI using si446x driver (currently out-of-tree at https://github.com/sunipkmukherjee/silabs.git)


This line is far too long - there is a hard limit of 80 characters in this file.

pelwell · 2021-07-05T13:48:29Z

arch/arm/boot/dts/overlays/si446x-spi0-overlay.dts

+/plugin/;
+
+   / {
+    compatible = "brcm,bcm2708";


This should be "brcm,bcm2835".

pelwell · 2021-07-05T13:49:15Z

arch/arm/boot/dts/overlays/si446x-spi0-overlay.dts

+                  <&uhf0>, "irq_pin:0",
+                  <&uhf0_pins>, "brcm,pins:0";
+        reset_pin = <&uhf0>, "sdn_pin:0",
+                    <&uhf0_pins>, "brcm,pins:1";


The offset for a parameter target is in bytes - this should say "brcm,pins:4".

sunipkm · 2021-07-05T19:49:08Z

There are a few small issues with the overlay and README entry that I've commented on, but the real problem with this PR is that without the driver people can't use it, and if they're building their own kernel/module they might as well build the overlay with it.

I agree with you that anyone using the driver can build their own overlay as well. I have submitted a message to LKML, and waiting for a follow up. In the mean time, the inclusion of the overlay can point people towards the code, and independent testing that will be very helpful. The available info/code about this transceiver is not large, which is why I am looking into getting this to a place that can benefit others.

Thanks for the corrections on the overlay.

…EADME

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

pelwell · 2021-07-13T08:11:37Z

Fixed up and merged offline.

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

kernel: KMS and FKMS right/bottom margin fixes See: raspberrypi/linux#4451 kernel: overlays: Add overlay for Si446x Transceiver SPI See: raspberrypi/linux#4430 kernel: ARM: dts: bcm2711: fold in the correct interrupt kernel: dtoverlays: Add overlay for cap1106 capacitive touch sensor See: raspberrypi/linux#4442 firmware: arm_loader: Add rng-seed DT property See: #1595 firmware: isp: Set the YUV420/YVU420 format stride to 64 byte

kernel: KMS and FKMS right/bottom margin fixes See: raspberrypi/linux#4451 kernel: overlays: Add overlay for Si446x Transceiver SPI See: raspberrypi/linux#4430 kernel: ARM: dts: bcm2711: fold in the correct interrupt kernel: dtoverlays: Add overlay for cap1106 capacitive touch sensor See: raspberrypi/linux#4442 firmware: arm_loader: Add rng-seed DT property See: raspberrypi/firmware#1595 firmware: isp: Set the YUV420/YVU420 format stride to 64 byte

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

commit 4d94d5c99bf36f3a11529277d3c7eef455ca352c from https://github.com/raspberrypi/linux.git rpi-5.10.y See: raspberrypi/linux#4430 Signed-off-by: Sunip K. Mukherjee <[email protected]> Signed-off-by: Meng Li <[email protected]>

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

See: raspberrypi#4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

pelwell · 2023-03-03T17:19:09Z

Did you get anywhere with the upstreaming? Some checking has just flagged silabs,si446x as a compatible string that isn't implemented by any drivers in our trees.

sunipkm · 2023-03-04T00:20:20Z

Hi Phil, Sorry to say it's been in development hell for a bit while I've been working on my PhD, I'll be going back to it in a next couple of months. There is a memory buffer bug in the implementation currently that I need to fix. Hope you are doing well. Sunip

…

On Fri, Mar 3, 2023, 12:19 PM Phil Elwell ***@***.***> wrote: Did you get anywhere with the upstreaming? Some checking has just flagged silabs,si446x as a compatible string that isn't implemented by any drivers in our trees. — Reply to this email directly, view it on GitHub <#4430 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADF2RQOM2YXCQ4A2SFQQLPDW2IRZTANCNFSM47Y6TNNA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

pelwell · 2023-03-06T08:48:29Z

No problem - I'll add the compatible string to the list of exceptions.

Added overlay for Si446x Transceiver SPI driver

d1c1f39

sunipkm force-pushed the rpi-5.10.y branch from 33fc917 to d1c1f39 Compare July 4, 2021 20:04

Fixed typo on si446x README entry

e8af15f

pelwell reviewed Jul 5, 2021

View reviewed changes

Fixed overlay compatible target and override byte offset, formatted R…

8611d60

…EADME

pelwell pushed a commit that referenced this pull request Jul 13, 2021

overlays: Add overlay for Si446x Transceiver SPI

4d94d5c

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

pelwell closed this Jul 13, 2021

pelwell pushed a commit that referenced this pull request Jul 14, 2021

overlays: Add overlay for Si446x Transceiver SPI

34e2e18

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

pelwell pushed a commit that referenced this pull request Jul 14, 2021

overlays: Add overlay for Si446x Transceiver SPI

35df518

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

pelwell pushed a commit that referenced this pull request Jul 14, 2021

overlays: Add overlay for Si446x Transceiver SPI

6270d89

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 15, 2021

overlays: Add overlay for Si446x Transceiver SPI

5ff4282

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 15, 2021

overlays: Add overlay for Si446x Transceiver SPI

ea276a6

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 21, 2021

overlays: Add overlay for Si446x Transceiver SPI

e41ca3e

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 21, 2021

overlays: Add overlay for Si446x Transceiver SPI

a182123

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 23, 2021

overlays: Add overlay for Si446x Transceiver SPI

3705c7b

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 27, 2021

overlays: Add overlay for Si446x Transceiver SPI

0214ed7

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 27, 2021

overlays: Add overlay for Si446x Transceiver SPI

a8be154

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Jul 27, 2021

overlays: Add overlay for Si446x Transceiver SPI

0bf2d65

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Aug 11, 2021

overlays: Add overlay for Si446x Transceiver SPI

5b674c2

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

Noltari pushed a commit to Noltari/rpi-linux that referenced this pull request Aug 20, 2021

overlays: Add overlay for Si446x Transceiver SPI

7f747c5

See: raspberrypi#4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Aug 21, 2021

overlays: Add overlay for Si446x Transceiver SPI

c3c224e

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Sep 8, 2021

overlays: Add overlay for Si446x Transceiver SPI

dbd721e

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Sep 15, 2021

overlays: Add overlay for Si446x Transceiver SPI

9a2d697

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

popcornmix pushed a commit that referenced this pull request Sep 30, 2021

overlays: Add overlay for Si446x Transceiver SPI

f4b9451

See: #4430 Signed-off-by: Sunip K. Mukherjee <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

char: silabs: si446x (SiLabs Si446x Transceiver) driver added. #4430

char: silabs: si446x (SiLabs Si446x Transceiver) driver added. #4430

sunipkm commented Jul 4, 2021

pelwell commented Jul 4, 2021

sunipkm commented Jul 4, 2021

pelwell left a comment

pelwell Jul 5, 2021

pelwell Jul 5, 2021

pelwell Jul 5, 2021

pelwell Jul 5, 2021

pelwell Jul 5, 2021

sunipkm commented Jul 5, 2021

pelwell commented Jul 13, 2021

pelwell commented Mar 3, 2023

sunipkm commented Mar 4, 2023 via email

pelwell commented Mar 6, 2023

		@@ -2720,6 +2720,12 @@ Params: speed SPI bus speed (default 4000000)
		reset_pin GPIO pin for RESET (default 25)
		height Display height (32 or 64; default 64)

char: silabs: si446x (SiLabs Si446x Transceiver) driver added. #4430

char: silabs: si446x (SiLabs Si446x Transceiver) driver added. #4430

Conversation

sunipkm commented Jul 4, 2021

pelwell commented Jul 4, 2021

sunipkm commented Jul 4, 2021

pelwell left a comment

Choose a reason for hiding this comment

pelwell Jul 5, 2021

Choose a reason for hiding this comment

pelwell Jul 5, 2021

Choose a reason for hiding this comment

pelwell Jul 5, 2021

Choose a reason for hiding this comment

pelwell Jul 5, 2021

Choose a reason for hiding this comment

pelwell Jul 5, 2021

Choose a reason for hiding this comment

sunipkm commented Jul 5, 2021

pelwell commented Jul 13, 2021

pelwell commented Mar 3, 2023

sunipkm commented Mar 4, 2023 via email

pelwell commented Mar 6, 2023