-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMS and FKMS right/bottom margin fixes #4451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
There's a typo in both commit messages ( |
LGTM |
Give me a couple of mins to correct the typo. |
The calculations clipped the right/bottom edge of the clipped range based on the left/top margins. Fixes: 666e735 ("drm/vc4: Take margin setup into account when updating planes") Signed-off-by: Dave Stevenson <[email protected]>
The calculations clipped the right/bottom edge of the clipped range based on the left/top margins. raspberrypi#4447 Signed-off-by: Dave Stevenson <[email protected]>
Done. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 14, 2021
kernel: KMS and FKMS right/bottom margin fixes See: raspberrypi/linux#4451 kernel: overlays: Add overlay for Si446x Transceiver SPI See: raspberrypi/linux#4430 kernel: ARM: dts: bcm2711: fold in the correct interrupt kernel: dtoverlays: Add overlay for cap1106 capacitive touch sensor See: raspberrypi/linux#4442 firmware: arm_loader: Add rng-seed DT property See: #1595 firmware: isp: Set the YUV420/YVU420 format stride to 64 byte
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jul 14, 2021
kernel: KMS and FKMS right/bottom margin fixes See: raspberrypi/linux#4451 kernel: overlays: Add overlay for Si446x Transceiver SPI See: raspberrypi/linux#4430 kernel: ARM: dts: bcm2711: fold in the correct interrupt kernel: dtoverlays: Add overlay for cap1106 capacitive touch sensor See: raspberrypi/linux#4442 firmware: arm_loader: Add rng-seed DT property See: raspberrypi/firmware#1595 firmware: isp: Set the YUV420/YVU420 format stride to 64 byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4447
There's still a further issue where you can create a plane that sits in the overscan area, so that'll be a follow on to clip the display objects to the visible area before scaling for overscan.