Use pico_unique_id as the USB device serial number #280
Conversation
…es missed thus obviating the need for an IRQ but there is an IRQ already pending for another timer (raspberrypi#243)
* pico_stdio_usb: be more explicit about includes, fix warning (raspberrypi#257) * pico_base: NDEBUG backwards for absolute_time_t (raspberrypi#255) * pico_util: missing extern C in queue.h (raspberrypi#249) * build: remove -march which was masking -mcpu, now SVC available (raspberrypi#253)
- Add double quotes because build option it's a string. - Remove comment as requested by @kilograham. - Resolves raspberrypi#258.
In order for the returned value to accurately reflect a single moment in time, ensure the registers are read just once and in the datasheet order. Before this change, the RTC registers would each be read multiple times, leading (infrequently) to the returned fields not all reflecting the same moment in time. The rp2040 datasheet has what I believe is an incorrect example (embedding the source of this function); will the datasheet be updated if this function is fixed? This problem is only a speculative one; I did not actually observe it in the wild.
- refactor to reduce duplication - add extra param-validation
Use the pico_unique_id to generate a unique serial number for the STDIO_USB device, allowing for individual boards to be identified.
|
I thought this was a duplicate, but I did a search and found raspberrypi/debugprobe#8 which is actually slightly different 😆 Can you rebase this against |
Use the pico_unique_id to generate a unique serial number for the STDIO_USB device, allowing for individual boards to be identified.
|
@lurch By inspection it looks like we get the same results. |
|
I wonder if it's worth adding a "common" |
|
As a lowly end user I was hesitant to suggest a new API call, but your suggestion does make sense (modulo the repeating copies if the buffer is too long...that seems like not the right thing to do). Let me adjust this PR accordingly. Then, if merged, picoprobe can be modified to use this new API and only 1 copy of the code will exist (yay!). |
| pico_unique_board_id_t id; | ||
| pico_get_unique_board_id(&id); | ||
|
|
||
| for (int i = 0; i < PICO_UNIQUE_BOARD_ID_SIZE_BYTES; i++) { |
There was a problem hiding this comment.
yeah, we should pull in printf etc. just to have the serial number. please replace with a trivial loop to fill in the hex values directly
|
ah i see this is concurrent editing... i'm ok with adding a helper function to do the trivial loop since it seems useful. |
|
also please rebase this onto develop not develop-1.1.1 @lurch steered you wrongly! |
Add a new API to pico_unique which will turn the unique ID into a canonical text string. Use this API to update the USB device serial number in stdio_usb. Supercedes raspberrypi#280
|
Closing due to being stuck in a weird git rebase heck. New PR #281 supersedes with the suggested new API and low-code implementation. |
* Add pico_get_unique_board_id_string API Add a new API to pico_unique which will turn the unique ID into a canonical text string. Use this API to update the USB device serial number in stdio_usb. Supercedes #280 * Clean up -Wconversion=error issues * Address review comments, fix api typing Use cleaner binary-to-hex conversion. Update the length parameter to use uint per the SDK standard .
Use the pico_unique_id to generate a unique serial number for the
STDIO_USB device, allowing for individual boards to be identified.