test: refactor tests for mocha

[silkentrance]

fix #137

WIP

• cleanups for outband tests are still missing
• failing discardDescriptor tests require fix(fileSync): must honor detachDescriptor and discardDescriptor options #149
• drop support for node < 0.10.0

[silkentrance]

Tests against the template option (here:effective gid mismatch) failed partly due to the fact that tmp will not join paths with opts.dir nor the default tmpDir. This resulted in the fact that the temporary files and directories will be created in the CWD.
I will file a new issue for this.

The second cause of the failure is more involved as it requires the parent directory to have the setgid bit set, which in turn will set the gid of the file or directory to that of the parent directory and not the effective gid of the current process. While this is not exactly a common requirement, I don't think that we should incorporate this into our tests, as it would involve stat'ing the parent directory and from that get the gid and see whether the gid matches that of the temporary file or directory. Since these are system specific issues, we should not be testing against these.
I'd favor removing the tests for egid and euid altogether as these are features of the underlying operating system which we do not control. In addition, these tests will not be run under the win32 platform.

[raszi]

Thank you @silkentrance for the hard work, this will help!

[silkentrance]

@raszi You're welcome. The existing tests that spawn child processes are still missing. I need to go through the code to find out how to do it with mocha...

[silkentrance]

rebased to master - failing tests due to #143

What do you think about the new tests?

[raszi]

I started the review but didn't have time to finish it. Here are my previous comments.

[raszi]

I think this should be put in the else branch of the following if condition, since that will be a stricter match and it would not add any value in the true case.

[raszi]

I meant this:

if (expected) {
  assert.equal(path.basename(name), expected, 'should be the expected name');
} else {
  assert.ok(name.length > 0, 'an empty string is not a valid name');
}

[silkentrance]

done.

[raszi]

Please remove the whitespace after the opening [ and the closing ].

[silkentrance]

done.

[raszi]

Please use whitespace after the opening { and before the closing }.

[silkentrance]

@raszi like so?

        it('should result in an error on negative tries', function () {

          try {
            tmp.dirSync({tries: -1});
            assert.fail('should have failed');
          } catch (err) {
            assert.ok(err instanceof Error);
          }

        });

ah, forget the above, I think you mean { tries: -1 }... but then again, there are lot of occurrences in the code where I could change that...

[silkentrance]

@raszi I will look over the existing issues with the code and commit these then as I already merged into master.