-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor tests for mocha #141
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ node_js: | |
- "4" | ||
- "0.12" | ||
- "0.10" | ||
- "0.8" | ||
sudo: false | ||
cache: | ||
directories: | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* eslint-disable no-octal */ | ||
|
||
var | ||
assert = require('assert'), | ||
fs = require('fs'), | ||
path = require('path'), | ||
existsSync = fs.existsSync || path.existsSync; | ||
|
||
|
||
module.exports.assertName = function assertName(name, expected) { | ||
assert.ok(typeof name == 'string'); | ||
assert.ok(name.length > 0, 'an empty string is not a valid name'); | ||
if (expected) { | ||
assert.equal(path.basename(name), expected, 'should be the expected name'); | ||
} | ||
}; | ||
|
||
|
||
module.exports.assertMode = function assertMode(name, mode) { | ||
var stat = fs.statSync(name); | ||
|
||
// mode values do not work properly on Windows. Ignore “group” and | ||
// “other” bits then. Ignore execute bit on that platform because it | ||
// doesn’t exist—even for directories. | ||
if (process.platform == 'win32') { | ||
assert.equal(stat.mode & 000600, mode & 000600); | ||
} else { | ||
assert.equal(stat.mode & 000777, mode); | ||
} | ||
}; | ||
|
||
|
||
module.exports.assertDir = function assertDir(name, dir) { | ||
assert.equal(name.slice(0, dir.length), dir, 'should have the expected dir as the leading path'); | ||
}; | ||
|
||
|
||
module.exports.assertPrefix = function assertPrefix(name, prefix) { | ||
assert.equal(path.basename(name).slice(0, prefix.length), prefix, 'should have the provided prefix'); | ||
}; | ||
|
||
|
||
module.exports.assertPostfix = function assertPostfix(name, postfix) { | ||
assert.equal(name.slice(name.length - postfix.length, name.length), postfix, 'should have the provided postfix'); | ||
}; | ||
|
||
|
||
module.exports.assertProperResult = function assertProperResult(result, withfd) { | ||
assert.ok(result); | ||
assert.ok(result.name, 'should have a name'); | ||
if (withfd) assert.ok(result.fd, 'should have an fd'); | ||
else assert.strictEqual(result.fd, undefined, 'should not have a file descriptor (fd)'); | ||
assert.ok(typeof result.removeCallback == 'function', 'should have a removeCallback'); | ||
}; | ||
|
||
|
||
module.exports.assertExists = function assertExists(name, isfile) { | ||
assert.ok(existsSync(name), name + ' should exist'); | ||
var stat = fs.statSync(name); | ||
if (isfile) assert.ok(stat.isFile(), name + ' should be a file'); | ||
else assert.ok(stat.isDirectory(), name + ' should be a directory'); | ||
}; | ||
|
||
|
||
module.exports.assertDoesNotExist = function assertDoesNotExist(name) { | ||
assert.ok(!existsSync(name), name + ' should not exist'); | ||
}; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be put in the else branch of the following if condition, since that will be a stricter match and it would not add any value in the true case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.