-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stabilize tmp for v0.2.0 release #234
Conversation
…iptor, similar to tmp.fileSync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good.
bc3dcab
to
7ee5bdd
Compare
…private functions to the back of the module
Future TODO
|
darn windows build is now failing with a EBADF, investigating |
fixed, needed YAWSWA (yet another windows specific work around)
|
|
||
## tmp v0.2.0 | ||
|
||
- drop support for node version < v8.17.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just realized that Node v8 was EOL in December.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it ok to release it for v8 (as its working) and drop support in feature version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just wanted to note.
ATM I do not have time for this, started on a new job and have to get up to speed there first. |
The travis-ci builds are no longer showing: https://travis-ci.org/github/raszi/node-tmp/builds/672652698 |
@raszi I think I am done with this PR. I fixed all the issues listed. You might want to have another look and if everything is ok, we can finally merge this and you can make a new 0.2.0 release 🚀 |
…so sanitize dir option, the template option and the name option
Nice work @silkentrance |
TODO