Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilize tmp for v0.2.0 release #234

Merged
merged 24 commits into from
Apr 9, 2020
Merged

feat: stabilize tmp for v0.2.0 release #234

merged 24 commits into from
Apr 9, 2020

Conversation

silkentrance
Copy link
Collaborator

@silkentrance silkentrance commented Feb 3, 2020

TODO

@silkentrance silkentrance mentioned this pull request Feb 3, 2020
test/mocha.opts Show resolved Hide resolved
Copy link
Owner

@raszi raszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good.

README.md Show resolved Hide resolved
@silkentrance
Copy link
Collaborator Author

silkentrance commented Feb 7, 2020

Future TODO

  • add missing tests for dir option, non-relative name, dir and template options, tries option, name generation in general

@silkentrance
Copy link
Collaborator Author

darn windows build is now failing with a EBADF, investigating

@silkentrance
Copy link
Collaborator Author

fixed, needed YAWSWA (yet another windows specific work around)

function _isExpectedError(error, errno, code) {
  return IS_WIN32 ? error.code === code : error.code === code && error.errno === errno;
}


## tmp v0.2.0

- drop support for node version < v8.17.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just realized that Node v8 was EOL in December.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to release it for v8 (as its working) and drop support in feature version?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just wanted to note.

@raszi raszi changed the title Stabilize tmp for v0.2.0 release feat: stabilize tmp for v0.2.0 release Feb 10, 2020
@silkentrance
Copy link
Collaborator Author

ATM I do not have time for this, started on a new job and have to get up to speed there first.

@silkentrance silkentrance linked an issue Apr 8, 2020 that may be closed by this pull request
7 tasks
@silkentrance
Copy link
Collaborator Author

The travis-ci builds are no longer showing:

https://travis-ci.org/github/raszi/node-tmp/builds/672652698

@silkentrance
Copy link
Collaborator Author

@raszi I think I am done with this PR. I fixed all the issues listed. You might want to have another look and if everything is ok, we can finally merge this and you can make a new 0.2.0 release 🚀

…so sanitize dir option, the template option and the name option
@raszi raszi merged commit b6465b0 into master Apr 9, 2020
@raszi
Copy link
Owner

raszi commented Apr 9, 2020

Nice work @silkentrance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmpNameSync: Bad result if the TMP/TEMP env. variables are enclosed in quotes
4 participants