feat: add learn and clear capability #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
reviewed
Dec 18, 2023
delete commented code on line 765
|
I'll try to test this week. I have family showing up for the holiday though so my time is quite limited at the moment |
|
Sounds good. I only have one gdo to test. If your wall controls send something other than LEARN_2 when pressed it might take some more research. |
|
Nice feature, it can save a climb up the ladder :) I'll give it a try on my GDO as well sometime this week. |
mariusmuja
reviewed
Dec 18, 2023
|
Extra scope being added for number of paired devices and function to clear devices. |
mulcmu
changed the title
|
I managed to test this, works great! I made a few minor changes (added an enum for the paired devices types) and improved the sync of paired devices (no need to sync all types multiple times on every sync step), I'll send a merge request against your branch. |
bdraco
changed the title
Minor changes
|
Yep just merged it. I didn't remember getting a message for the PR...apparently github doesn't default to watching your own forks. |
|
Great! @bdraco we should merge this, it worked great for me and it's a useful feature. |
|
pushed to repo as |
|
I'm getting unavailable on the toggle door button for one GDO after flashing this. I'm digging in as it makes no sense 
|
There is a pretty significant drop in free memory with this PR |
mariusmuja
reviewed
Jan 18, 2024
|
Button issue is not caused by this PR. I fixed it in home-assistant/core#108316 |
bdraco
reviewed
Jan 18, 2024
|
Found a blocker. If I press the learn button on the wall control, the learn switch turns on, and than I exit out on the wall control, the learn switch turns off and the rolling code counter increments about every second until I reboot the esp RPReplay_Final1705610628.mp4 |
|
Logs |
|
The ESP buffer gets swamped and eventually disconnects after it gets into this state because it can't send the keep alive |
|
I just tested toggle learn on/off from wall control. Couldn't quite recreate your issue but, my learn switch did not turn off now when cleared by the wall control. I'll investigate more this evening. |
|
I just had a quick look too. When I exit the Lean/Program menu on the wall panel, the GDO stays in learn mode (the Learn switch stays checked in esphome), also the learn led stays lit on the GDO. @mulcmu Why do we need to poll status while in learn mode? Just to update the switch status? We can leave that to the 5min status messages if the GDO doesn't send a status anyway when exiting learn mode (mine does when entering and exiting learn mode). |
|
I tested removing the polling and it does turn off after 5 minute timeout I'll get that pulled out and get this merged since its blocking the other PR. We can revisit in a follow up PR if needed |
bdraco
approved these changes
Jan 18, 2024
|
Thanks @mulcmu Great addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a switch that will initiate the remote learning cycle. Switch tracks learn initiated by gdo button and wall control as well. Toggling switch back off will terminate the learn cycle initiated by ratgdo, gdo, or the wall control. Learn timeout was about 3 minutes on my gdo.
Test cases, door open by using ratgdo, gdo, & wall control to
Repeated tests with door closed.
Learn initiated by wall control causes wall control status LED to flash. It doesn't return to normal when learn is deactivated by ratgdo until the gdo light state changes or door is operated. It keeps spamming GET_STATUS every second until status LED returns to normal. This might just be a quirk of the wall panel firmware ignoring STATUS messages it didn't request. It doesn't seem to hurt anything and would be a pretty rare edge case anyway.
clang-format --style=Webkitformatted.