feat: Security Plus v1 support #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulWieland
reviewed
Jan 12, 2024
components/ratgdo/secplus1.cpp
Outdated
| @@ -297,6 +297,12 @@ namespace secplus1 { | |||
| if (cmd.value == 0x31) { | |||
| this->wall_panel_starting_ = true; | |||
| } | |||
| } else if (cmd.type == CommandType::TOGGLE_LIGHT_REQ) { | |||
| // motion was detected, or the light toggle button was pressed | |||
| // either way it's ok to trigger motion detection | |||
There was a problem hiding this comment.
That's a novel way of looking at it. Nicely done :)
There was a problem hiding this comment.
Ah...that makes sense why i was briefly seeing motion being detected despite the motion sensor itself never actually triggering anything in my few minutes of testing the sec+ 1.0 stuff. 👍🏻
|
Just wanted to confirm that this is able to open and close my garage door with a LiftMaster 8500, mfg date 03/08/17. Have not exercised full integration, but it does trigger open and close automations, so it's able to open/close, and communicate status to HA. |
|
I'm not seeing the movement sensor on my 8500; is there anything I can do to assist in debugging? How would I find the message being passed? |
There is no message passed when motion is detected on sec+1, the wall panel just turns on the light. We trigger a motion event when detecting a light toggle message. Once the light is on, no motion events occur. |
|
Looks like this is getting close to ready. When you want to merge, let me know, and I'll do some testing with my V2 openers to make sure there's no regressions After this PR, I think we probably need to clean the website up a little bit to make it clear which one you need to use with which garage door opener, but that can be the next PR |
|
Once thing I noticed is that debug logs (the default log level when enabling the logger component) in this branch are much more verbose than they were on the original branch (because |
No, it's super verbose now because I have no sec+1.0 hardware to test, so I relied on logs from other people and needed to see exactly what's happening. Most of the logging will be removed/changed to ESP_LOGV when merging to main. |
|
i can help test on some sec+1.0 hardware if needed. currently running mqtt with an 889LM wall panel. Whats my migration path to one of these builds? can i ota flash through the mqtt build website? |
|
FYI I'm also testing on sec+1.0 hardware from about 20 years ago. I've got an 888LM wall panel I just put in ($2 from a thrift store years ago just sitting on a shelf in the garage, and finally just installed it 😂), but seems to be basically the same as 889LM. So far everything looks good. I've tested the following:
Only thing I don't get is motion but that's because sec+1.0 doesn't include that information...that information stays local to the wall panel, and the wall panel itself sends the signal to turn on the light. |
|
#149 is merged now so you should be all clear to resolve conflicts now |
…lus1 implementation.
Nice! |
|
The blocking issue is gone now that the flash issue is sorted and logging is reduced |
|
I can't make the crash happen again either so it might be the thread safety issue |
|
Great! I'm looking now at the optimistic door status change when opening/closing. |
|
I'm seeing some type of loop when stopping the door when opening at 95% |
That doesn't look good... Can you reproduce it with more logging? |
|
Doing that now. The device is completely unresponsive in HA but continues to log. 🤞 that I can OTA with out getting the ladder back out |
|
reflashed, now I can't get it back into the bad state 🙈 |
|
I did get another crash with the logging turned up |
|
Got it back into the bad state |
|
Looks like ratgdo missed the status command again here: The door is open/stopped at this point and ratgdo doesn't know it and keeps trying to stop it through the This is a bug, at the very least Btw, is this GDO the DC motor kind with a bettery backup. There's several people (me included) having issues with this kind of GDOs since the weather got cold, they don't bring the data line all the way to ground when transmitting which results in missed responses from the GDO. |
|
It did eventually get unstuck and than crash: Here is the full log: |
|
Its a DC battery one. But its in in Hawaii so cold is not the issue for sure |
Haha... yeah. Then cold just makes the issue worse (or it's completely unrelated). |
It got unstuck because the 5min status message arrived and door status changed. I pushed the fix to optimistically update door position after the open/close duration which would have avoided this bug. But I'm thinking to remove ensure door action as well.... |
|
The flurry of |
Yeah, I'm just looking why there's so many |
There's just one |
|
All seems good now I'll clean things up and get this merged |
|
Awesome work @mariusmuja 🐬 👍 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test YAML (the substitutions need to be adjusted depending on which board is used)