Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect payload doc for creating ray jobs in apiserver #1290

Closed
1 of 2 tasks
js8544 opened this issue Aug 3, 2023 · 2 comments · Fixed by #1435
Closed
1 of 2 tasks

[Bug] Incorrect payload doc for creating ray jobs in apiserver #1290

js8544 opened this issue Aug 3, 2023 · 2 comments · Fixed by #1435
Assignees
Labels
apiserver bug Something isn't working

Comments

@js8544
Copy link

js8544 commented Aug 3, 2023

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

apiserver

What happened + What you expected to happen

https://github.com/ray-project/kuberay/tree/master/apiserver#create-ray-job-in-a-given-namespace
https://ray-project.github.io/kuberay/components/apiserver/#create-ray-job-in-a-given-namespace

I believe the documented payload for creating ray jobs is actually the response for getting ray jobs.

Reproduction script

N/A

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@js8544 js8544 added the bug Something isn't working label Aug 3, 2023
@kevin85421
Copy link
Member

cc @blublinsky @anishasthana

@z103cb
Copy link
Contributor

z103cb commented Sep 6, 2023

@kevin85421 can you also assign this ticket to me also ?

z103cb added a commit to z103cb/kuberay that referenced this issue Sep 18, 2023
z103cb added a commit to z103cb/kuberay that referenced this issue Sep 20, 2023
z103cb added a commit to z103cb/kuberay that referenced this issue Sep 22, 2023
z103cb added a commit to z103cb/kuberay that referenced this issue Sep 25, 2023
z103cb added a commit to z103cb/kuberay that referenced this issue Sep 26, 2023
z103cb added a commit to z103cb/kuberay that referenced this issue Sep 26, 2023
kevin85421 pushed a commit that referenced this issue Sep 26, 2023
* Updated API server documentation
Fixes #1290

* Address PR review comments.
Fixed api server helm install command.

* [Bug] Incorrect payload doc for creating ray jobs in apiserver
Fixes #1290
kevin85421 pushed a commit to kevin85421/kuberay that referenced this issue Oct 17, 2023
* Updated API server documentation
Fixes ray-project#1290

* Address PR review comments.
Fixed api server helm install command.

* [Bug] Incorrect payload doc for creating ray jobs in apiserver
Fixes ray-project#1290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apiserver bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants