Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API server documentation #1435

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

z103cb
Copy link
Contributor

@z103cb z103cb commented Sep 18, 2023

Why are these changes needed?

The API Server examples are out of date. This PR updates the examples.
Please note that the API server examples for this PR where tested on #1419.

Related issue number

Closes #1290
Contributes to #1408

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@z103cb
Copy link
Contributor Author

z103cb commented Sep 18, 2023

@tedhtchang, @blublinsky and @anishasthana please take a look when you can.
cc: @kevin85421

apiserver/README.md Show resolved Hide resolved
apiserver/README.md Outdated Show resolved Hide resolved
apiserver/README.md Outdated Show resolved Hide resolved
apiserver/README.md Outdated Show resolved Hide resolved
@z103cb z103cb force-pushed the z103cb/issue1290 branch 2 times, most recently from 1c2f6f0 to 36f3249 Compare September 25, 2023 11:54
apiserver/README.md Show resolved Hide resolved
apiserver/README.md Show resolved Hide resolved
apiserver/README.md Show resolved Hide resolved
apiserver/README.md Show resolved Hide resolved
Copy link
Contributor

@blublinsky blublinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@anishasthana
Copy link
Contributor

cc @kevin85421

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@kevin85421 kevin85421 merged commit 6b12c18 into ray-project:master Sep 26, 2023
21 of 22 checks passed
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
* Updated API server documentation
Fixes ray-project#1290

* Address PR review comments.
Fixed api server helm install command.

* [Bug] Incorrect payload doc for creating ray jobs in apiserver
Fixes ray-project#1290
@kevin85421 kevin85421 mentioned this pull request Dec 28, 2023
4 tasks
@z103cb z103cb deleted the z103cb/issue1290 branch February 5, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect payload doc for creating ray jobs in apiserver
5 participants